update/refactor defeault clnrest values

Author: gudnuf

lightningd/plugin.c

@@ -1423,6 +1423,7 @@ static const char *plugin_rpcmethod_clnrest_add(struct plugin *plugin,
 {
 	const jsmntok_t *clnresttok = json_get_member(buffer, tok, "clnrest");
 
+	/** clnrest is an optional field*/
 	if (!clnresttok) {
 		cmd->clnrest = NULL;
 		return NULL;
@@ -1438,34 +1439,41 @@ static const char *plugin_rpcmethod_clnrest_add(struct plugin *plugin,
 	const jsmntok_t *contenttypetok =
 	    json_get_member(buffer, clnresttok, "content_type");
 	const jsmntok_t *runetok = json_get_member(buffer, clnresttok, "rune");
-	const jsmntok_t *pluginnametok = json_get_member(buffer, tok, "name");
+	const jsmntok_t *cmdnametok = json_get_member(buffer, tok, "name");
+
+	/** If clnrest is present, then all fields get populated */
+	const char *default_method = "POST";
+	const char *default_content_type = "application/json";
+	bool default_rune_value = true;
+	const char *cmd_name = json_strdup(tmpctx, buffer, cmdnametok);
+	const char *default_path = tal_fmt(plugin, "/v1/%s", cmd_name);
 
 	if (pathtok) {
 		clnrest->path = json_strdup(clnrest, buffer, pathtok);
 		tal_free(default_path);
 	} else {
-		clnrest->path = json_strdup(clnrest, buffer, pluginnametok);
+		clnrest->path = default_path;
 	}
 
 	if (methodtok) {
 		clnrest->method = json_strdup(clnrest, buffer, methodtok);
 	} else {
-		clnrest->method = "GET";
+		clnrest->method = default_method;
 	}
 
 	if (contenttypetok) {
 		clnrest->content_type =
 		    json_strdup(clnrest, buffer, contenttypetok);
 	} else {
-		clnrest->content_type = "application/json";
+		clnrest->content_type = default_content_type;
 	}
 
+	/** whether or not this route requires a rune for authentication */
 	if (runetok) {
 		bool rune_value;
 		json_to_bool(buffer, runetok, &rune_value);
 		clnrest->rune = tal_dup(clnrest, bool, &rune_value);
 	} else {
-		bool default_rune_value = true;
 		clnrest->rune = tal_dup(clnrest, bool, &default_rune_value);
 	}