docs: fix htlc states description regarding direction

Changelog-None

Author: daywalker90

cln-grpc/proto/node.proto

@@ -31,6 +31,7 @@ pub enum ChannelState {
     DUALOPEND_OPEN_COMMIT_READY = 13,
 }
 
+/// ['The first 10 states are for `out`, the next 10 are for `in`.']
 #[derive(Copy, Clone, Serialize, Deserialize, Debug, PartialEq, Eq)]
 #[allow(non_camel_case_types)]
 pub enum HtlcState {
@@ -106,6 +107,19 @@ impl TryFrom<i32> for AutocleanSubsystem {
     }
 }
 
+impl Display for AutocleanSubsystem {
+    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        match self {
+            AutocleanSubsystem::SUCCEEDEDFORWARDS => write!(f, "SUCCEEDEDFORWARDS"),
+            AutocleanSubsystem::FAILEDFORWARDS => write!(f, "FAILEDFORWARDS"),
+            AutocleanSubsystem::SUCCEEDEDPAYS => write!(f, "SUCCEEDEDPAYS"),
+            AutocleanSubsystem::FAILEDPAYS => write!(f, "FAILEDPAYS"),
+            AutocleanSubsystem::PAIDINVOICES => write!(f, "PAIDINVOICES"),
+            AutocleanSubsystem::EXPIREDINVOICES => write!(f, "EXPIREDINVOICES"),
+        }
+    }
+}
+
 #[derive(Copy, Clone, Serialize, Deserialize, Debug)]
 #[allow(non_camel_case_types)]
 pub enum PluginSubcommand {
@@ -452,6 +466,27 @@ impl TryFrom<i32> for ChannelState {
     }
 }
 
+impl Display for ChannelState {
+    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        match self {
+            ChannelState::OPENINGD => write!(f, "OPENINGD"),
+            ChannelState::CHANNELD_AWAITING_LOCKIN => write!(f, "CHANNELD_AWAITING_LOCKIN"),
+            ChannelState::CHANNELD_NORMAL => write!(f, "CHANNELD_NORMAL"),
+            ChannelState::CHANNELD_SHUTTING_DOWN => write!(f, "CHANNELD_SHUTTING_DOWN"),
+            ChannelState::CLOSINGD_SIGEXCHANGE => write!(f, "CLOSINGD_SIGEXCHANGE"),
+            ChannelState::CLOSINGD_COMPLETE => write!(f, "CLOSINGD_COMPLETE"),
+            ChannelState::AWAITING_UNILATERAL => write!(f, "AWAITING_UNILATERAL"),
+            ChannelState::FUNDING_SPEND_SEEN => write!(f, "FUNDING_SPEND_SEEN"),
+            ChannelState::ONCHAIN => write!(f, "ONCHAIN"),
+            ChannelState::DUALOPEND_OPEN_INIT => write!(f, "DUALOPEND_OPEN_INIT"),
+            ChannelState::DUALOPEND_AWAITING_LOCKIN => write!(f, "DUALOPEND_AWAITING_LOCKIN"),
+            ChannelState::CHANNELD_AWAITING_SPLICE => write!(f, "CHANNELD_AWAITING_SPLICE"),
+            ChannelState::DUALOPEND_OPEN_COMMITTED => write!(f, "DUALOPEND_OPEN_COMMITTED"),
+            ChannelState::DUALOPEND_OPEN_COMMIT_READY => write!(f, "DUALOPEND_OPEN_COMMIT_READY"),
+        }
+    }
+}
+
 impl From<i32> for ChannelTypeName {
     fn from(value: i32) -> Self {
         match value {
@@ -479,6 +514,21 @@ impl From<ChannelTypeName> for i32 {
     }
 }
 
+impl Display for ChannelTypeName {
+    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        match self {
+            ChannelTypeName::STATIC_REMOTEKEY_EVEN => write!(f, "STATIC_REMOTEKEY_EVEN"),
+            ChannelTypeName::ANCHOR_OUTPUTS_EVEN => write!(f, "ANCHOR_OUTPUTS_EVEN"),
+            ChannelTypeName::ANCHORS_ZERO_FEE_HTLC_TX_EVEN => {
+                write!(f, "ANCHORS_ZERO_FEE_HTLC_TX_EVEN")
+            }
+            ChannelTypeName::SCID_ALIAS_EVEN => write!(f, "SCID_ALIAS_EVEN"),
+            ChannelTypeName::ZEROCONF_EVEN => write!(f, "ZEROCONF_EVEN"),
+            ChannelTypeName::ANCHORS_EVEN => write!(f, "ANCHORS_EVEN"),
+        }
+    }
+}
+
 impl From<i32> for HtlcState {
     fn from(value: i32) -> Self {
         match value {
@@ -508,6 +558,33 @@ impl From<i32> for HtlcState {
     }
 }
 
+impl Display for HtlcState {
+    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        match self {
+            HtlcState::SENT_ADD_HTLC => write!(f, "SENT_ADD_HTLC"),
+            HtlcState::SENT_ADD_COMMIT => write!(f, "SENT_ADD_COMMIT"),
+            HtlcState::RCVD_ADD_REVOCATION => write!(f, "RCVD_ADD_REVOCATION"),
+            HtlcState::RCVD_ADD_ACK_COMMIT => write!(f, "RCVD_ADD_ACK_COMMIT"),
+            HtlcState::SENT_ADD_ACK_REVOCATION => write!(f, "SENT_ADD_ACK_REVOCATION"),
+            HtlcState::RCVD_ADD_ACK_REVOCATION => write!(f, "RCVD_ADD_ACK_REVOCATION"),
+            HtlcState::RCVD_REMOVE_HTLC => write!(f, "RCVD_REMOVE_HTLC"),
+            HtlcState::RCVD_REMOVE_COMMIT => write!(f, "RCVD_REMOVE_COMMIT"),
+            HtlcState::SENT_REMOVE_REVOCATION => write!(f, "SENT_REMOVE_REVOCATION"),
+            HtlcState::SENT_REMOVE_ACK_COMMIT => write!(f, "SENT_REMOVE_ACK_COMMIT"),
+            HtlcState::RCVD_REMOVE_ACK_REVOCATION => write!(f, "RCVD_REMOVE_ACK_REVOCATION"),
+            HtlcState::RCVD_ADD_HTLC => write!(f, "RCVD_ADD_HTLC"),
+            HtlcState::RCVD_ADD_COMMIT => write!(f, "RCVD_ADD_COMMIT"),
+            HtlcState::SENT_ADD_REVOCATION => write!(f, "SENT_ADD_REVOCATION"),
+            HtlcState::SENT_ADD_ACK_COMMIT => write!(f, "SENT_ADD_ACK_COMMIT"),
+            HtlcState::SENT_REMOVE_HTLC => write!(f, "SENT_REMOVE_HTLC"),
+            HtlcState::SENT_REMOVE_COMMIT => write!(f, "SENT_REMOVE_COMMIT"),
+            HtlcState::RCVD_REMOVE_REVOCATION => write!(f, "RCVD_REMOVE_REVOCATION"),
+            HtlcState::RCVD_REMOVE_ACK_COMMIT => write!(f, "RCVD_REMOVE_ACK_COMMIT"),
+            HtlcState::SENT_REMOVE_ACK_REVOCATION => write!(f, "SENT_REMOVE_ACK_REVOCATION"),
+        }
+    }
+}
+
 impl<'de> Deserialize<'de> for Amount {
     fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
     where

cln-rpc/src/model.rs

@@ -216,6 +216,7 @@ class OverridePatch(Patch):
         "channel_state_changed.old_state": "ChannelState",
         "channel_state_changed.new_state": "ChannelState",
         "ListPeerChannels.channels[].state": "ChannelState",
+        "Wait.htlcs.state": "HtlcState",
     }
 
     def visit(self, f: model.Field, parent: Optional[model.Field] = None) -> None:

cln-rpc/src/primitives.rs

@@ -21056,7 +21056,7 @@
                     "SENT_REMOVE_ACK_REVOCATION"
                   ],
                   "description": [
-                    "The first 10 states are for `in`, the next 10 are for `out`."
+                    "The first 10 states are for `out`, the next 10 are for `in`."
                   ]
                 }
               }
@@ -34660,7 +34660,7 @@
                       ],
                       "added": "v25.05",
                       "description": [
-                        "The first 10 states are for `in`, the next 10 are for `out`."
+                        "The first 10 states are for `out`, the next 10 are for `in`."
                       ]
                     },
                     "htlc_id": {

contrib/msggen/msggen/patch.py

@@ -148,7 +148,7 @@
                 "SENT_REMOVE_ACK_REVOCATION"
               ],
               "description": [
-                "The first 10 states are for `in`, the next 10 are for `out`."
+                "The first 10 states are for `out`, the next 10 are for `in`."
               ]
             }
           }

contrib/msggen/msggen/schema.json

@@ -482,7 +482,7 @@
                   ],
                   "added": "v25.05",
                   "description": [
-                    "The first 10 states are for `in`, the next 10 are for `out`."
+                    "The first 10 states are for `out`, the next 10 are for `in`."
                   ]
                 },
                 "htlc_id": {