fixup! add listing options to listpays

Author: rustyrussell

plugins/pay.c

@@ -419,8 +419,7 @@ static void add_new_entry(struct json_stream *ret,
 		json_add_u64(ret, "number_of_parts",
 			     pm->num_nonfailed_parts);
 
-	if(pm->created_index)
-		json_add_u64(ret, "created_index", pm->created_index);
+	json_add_u64(ret, "created_index", pm->created_index);
 
 	if(pm->updated_index)
 		json_add_u64(ret, "updated_index", pm->updated_index);
@@ -527,6 +526,15 @@ static struct command_result *listsendpays_done(struct command *cmd,
 				pm->invstring = tal_steal(pm, invstr);
 			if (!pm->description)
 				pm->description = json_get_member(buf, t, "description");
+			/* What's the "created_index" of the merged record?
+			 * We take the *lowest*, since that will never change
+			 * (unless they delete payments!). */
+			if (created_index < pm->created_index)
+				pm->created_index = created_index;
+			/* On the other hand, we take the *highest*
+			 * updated_index, so we see any changes. */
+			if (updated_index > pm->updated_index)
+				pm->updated_index = updated_index;
 		}
 
 		status = json_get_member(buf, t, "status");

tests/test_pay.py

@@ -6267,7 +6267,7 @@ def test_injectpaymentonion_selfpay(node_factory, executor):
                     'amount_sent_msat': 1000,
                     'number_of_parts': 2,
                     'created_index': 2,
-                    'updated_index': 2}
+                    'updated_index': 3}
 
     # Test self-pay with MPP from non-selfpay.
     inv6 = l2.rpc.invoice(3000, "test_injectpaymentonion6", "test_injectpaymentonion6")