fixup! Splice: Clone psbts instead of steal

Author: ddustin

channeld/channeld.c

@@ -4163,7 +4163,7 @@ static void splice_initiator_user_update(struct peer *peer, const u8 *inmsg)
 	assert(peer->splicing->current_psbt);
 	/* peer->splicing->current_psbt represents what PSBT we have sent to
 	 * our peer so far. */
-	ictx->current_psbt = peer->splicing->current_psbt;
+	ictx->current_psbt = clone_psbt(ictx, peer->splicing->current_psbt);
 	ictx->tx_add_input_count = peer->splicing->tx_add_input_count;
 	ictx->tx_add_output_count = peer->splicing->tx_add_output_count;
 
@@ -4190,8 +4190,7 @@ static void splice_initiator_user_update(struct peer *peer, const u8 *inmsg)
 	peer->splicing->tx_add_input_count = ictx->tx_add_input_count;
 	peer->splicing->tx_add_output_count = ictx->tx_add_output_count;
 
-	if (peer->splicing->current_psbt != ictx->current_psbt)
-		tal_free(peer->splicing->current_psbt);
+	tal_free(peer->splicing->current_psbt);
 	peer->splicing->current_psbt = clone_psbt(peer->splicing,
 						  ictx->current_psbt);
 

common/interactivetx.c

@@ -408,9 +408,6 @@ char *process_interactivetx_updates(const tal_t *ctx,
 	 * Otherwise we advance `current_psbt` to `next_psbt` and begin
 	 * processing the change set in `ictx->change_set` */
 	if (ictx->current_psbt != next_psbt) {
-		/* psbt_get_changeset requires we keep the current_psbt until
-		 * we're done withh change_set */
-		tal_steal(ictx->change_set, ictx->current_psbt);
 		ictx->current_psbt = next_psbt;
 	}
 
@@ -806,7 +803,5 @@ char *process_interactivetx_updates(const tal_t *ctx,
 	/* Sort psbt! */
 	psbt_sort_by_serial_id(ictx->current_psbt);
 
-	tal_steal(ictx, ictx->current_psbt);
-
 	return NULL;
 }