lightningd: remove --experimental-quiesce and --experimental-offers

Deprecated 24.11, disabled 25.05 (they're the default now).

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Removed: Config: --experimental-offers and --experimental-quiesce (default since v24.11)

Author: rustyrussell

doc/developers-guide/deprecated-features.md

@@ -11,7 +11,6 @@ hidden: false
 | decodepay                            | Command            | v24.11           | v25.12         | Use `decode` which is more powerful (since v23.05)                                                                                     |
 | close.tx                             | Field              | v24.11           | v25.12         | Use txs array instead                                                                                                                  |
 | close.txid                           | Field              | v24.11           | v25.12         | Use txids array instead                                                                                                                |
-| experimental-offers                  | Config             | v24.11           | v25.05         | Now the default                                                                                                                        |
 | xpay.ignore_bolt12_mpp               | Field              | v25.05           | v25.12         | Try MPP even if the BOLT12 invoice doesn't explicitly allow it (CLN didn't until 25.02)                                                |
 | listpeerchannels.max_total_htlc_in_msat | Field           | v25.02           | v26.03         | Use our_max_total_htlc_out_msat                                                                                                              |
 | wait.details                         | Field              | v25.05           | v26.06         | Use subsystem-specific object instead                                                                                                  |

lightningd/options.c

@@ -1253,23 +1253,6 @@ static char *opt_set_peer_storage(struct lightningd *ld)
 	return NULL;
 }
 
-static char *opt_set_quiesce(struct lightningd *ld)
-{
-	if (!opt_deprecated_ok(ld, "experimental-quiesce", NULL,
-			       "v24.11", "v25.05"))
-		return "--experimental-quiesce is now enabled by default";
-	return NULL;
-}
-
-static char *opt_set_offers(struct lightningd *ld)
-{
-	if (!opt_deprecated_ok(ld, "experimental-offers", NULL,
-			       "v24.11", "v25.05"))
-		return "--experimental-offers has been deprecated (now the default)";
-
-	return NULL;
-}
-
 static char *opt_set_db_upgrade(const char *arg, struct lightningd *ld)
 {
 	ld->db_upgrade_ok = tal(ld, bool);
@@ -1440,9 +1423,6 @@ static void register_opts(struct lightningd *ld)
 				 " channels using splicing");
 
 	/* This affects our features, so set early. */
-	opt_register_early_noarg("--experimental-offers",
-				 opt_set_offers, ld,
-				 opt_hidden);
 	opt_register_early_noarg("--experimental-shutdown-wrong-funding",
 				 opt_set_shutdown_wrong_funding, ld,
 				 "EXPERIMENTAL: allow shutdown with alternate txids");