pytest: restore and fix disabled test test_excluded_adjacent_routehint.

1. It was flaky, probably because it didn't wait for the remote update_channel.
2. Rusty applied a fix in 5f664da, not clear if it worked.
3. Christian disabled it altogether in 23ce9a9.

Signed-off-by: Rusty Russell <[email protected]>

Author: rustyrussell

lightningd/connect_control.c

@@ -286,7 +286,8 @@ static void connect_failed(struct lightningd *ld,
 	 * does simply combine those, so we don't get a response per request, and it's a
 	 * very rare corner case (which, unlike the above, doesn't happen in CI!).
 	 */
-	if (strstarts(connect_reason, "connect command")) {
+	if (strstarts(connect_reason, "connect command")
+	    || errcode == CONNECT_DISCONNECTED_DURING) {
 		/* We can have multiple connect commands: fail them all */
 		while ((c = find_connect(ld, id)) != NULL) {
 			/* They delete themselves from list */

tests/test_pay.py

@@ -3469,7 +3469,6 @@ def test_reject_invalid_payload(node_factory):
     l2.daemon.wait_for_log(r'Failing HTLC because of an invalid payload')
 
 
-@unittest.skip("Test is flaky causing CI to be unusable.")
 def test_excluded_adjacent_routehint(node_factory, bitcoind):
     """Test case where we try have a routehint which leads to an adjacent
     node, but the result exceeds our maxfee; we crashed trying to find
@@ -3478,10 +3477,15 @@ def test_excluded_adjacent_routehint(node_factory, bitcoind):
     """
     l1, l2, l3 = node_factory.line_graph(3)
 
+    # Make sure l2->l3 is usable.
+    wait_for(lambda: 'remote' in only_one(l3.rpc.listpeerchannels()['channels'])['updates'])
+
     # We'll be forced to use routehint, since we don't know about l3.
     inv = l3.rpc.invoice(10**3, "lbl", "desc", exposeprivatechannels=l2.get_channel_scid(l3))
 
-    l1.wait_channel_active(l1.get_channel_scid(l2))
+    # Make sure l1->l2 is usable.
+    wait_for(lambda: 'remote' in only_one(l1.rpc.listpeerchannels()['channels'])['updates'])
+
     # This will make it reject the routehint.
     err = r'Fee exceeds our fee budget: 1msat > 0msat, discarding route'
     with pytest.raises(RpcError, match=err):