askrene: add compiler flag ASKRENE_UNITTEST

Rusty: "We don't generally use NDEBUG in our code"

Instead use a compile time flag ASKRENE_UNITTEST to make checks on unit
tests that we don't normally need on release code.

Changelog-none

Signed-off-by: Lagrang3 <[email protected]>

Author: Lagrang3

plugins/askrene/algorithm.c

@@ -402,7 +402,7 @@ static struct node dijkstra_nearest_sink(const tal_t *ctx,
 		prev[i].idx = INVALID_INDEX;
 
 /* Only in debug mode we keep track of visited nodes. */
-#ifndef NDEBUG
+#ifdef ASKRENE_UNITTEST
 	bitmap *visited =
 	    tal_arrz(this_ctx, bitmap, BITMAP_NWORDS(max_num_nodes));
 	assert(visited);
@@ -421,7 +421,7 @@ static struct node dijkstra_nearest_sink(const tal_t *ctx,
 		priorityqueue_pop(q);
 
 /* Only in debug mode we keep track of visited nodes. */
-#ifndef NDEBUG
+#ifdef ASKRENE_UNITTEST
 		assert(!bitmap_test_bit(visited, cur.idx));
 		bitmap_set_bit(visited, cur.idx);
 #endif
@@ -598,7 +598,7 @@ bool mcf_refinement(const tal_t *ctx,
 		}
 	}
 
-#ifndef NDEBUG
+#ifdef ASKRENE_UNITTEST
 	/* verify that we have satisfied all constraints */
 	for (u32 i = 0; i < max_num_nodes; i++) {
 		assert(excess[i] == 0);

plugins/askrene/test/run-bfs.c

@@ -6,6 +6,7 @@
 #include <plugins/askrene/graph.h>
 #include <stdio.h>
 
+#define ASKRENE_UNITTEST
 #include "../algorithm.c"
 
 #define MAX_NODES 256

plugins/askrene/test/run-dijkstra.c

@@ -6,6 +6,7 @@
 #include <plugins/askrene/graph.h>
 #include <stdio.h>
 
+#define ASKRENE_UNITTEST
 #include "../algorithm.c"
 
 // 1->2 7

plugins/askrene/test/run-flow.c

@@ -6,6 +6,7 @@
 #include <plugins/askrene/graph.h>
 #include <stdio.h>
 
+#define ASKRENE_UNITTEST
 #include "../algorithm.c"
 
 #define MAX_NODES 256

plugins/askrene/test/run-graph.c

@@ -6,6 +6,7 @@
 #include <inttypes.h>
 #include <stdio.h>
 
+#define ASKRENE_UNITTEST
 #include "../graph.c"
 
 #define MAX_NODES 10

plugins/askrene/test/run-mcf-large.c

@@ -6,6 +6,7 @@
 #include <plugins/askrene/graph.h>
 #include <stdio.h>
 
+#define ASKRENE_UNITTEST
 #include "../algorithm.c"
 
 #ifdef HAVE_ZLIB

plugins/askrene/test/run-mcf.c

@@ -6,6 +6,7 @@
 #include <plugins/askrene/graph.h>
 #include <stdio.h>
 
+#define ASKRENE_UNITTEST
 #include "../algorithm.c"
 
 #define CHECK(arg) if(!(arg)){fprintf(stderr, "failed CHECK at line %d: %s\n", __LINE__, #arg); abort();}

plugins/askrene/test/run-pqueue.c

@@ -5,7 +5,7 @@
 #include <inttypes.h>
 #include <stdio.h>
 
-
+#define ASKRENE_UNITTEST
 #include "../priorityqueue.c"
 
 #define CHECK(arg) if(!(arg)){fprintf(stderr, "failed CHECK at line %d: %s\n", __LINE__, #arg); abort();}