secp256k1 pubkey constant fix

ddustin · rustyrussell · commit 9708ee316646 · 2024-11-17T10:55:28.000+10:30
Spotted a number being used instead of the macro constant.

Changelog-None
diff --git a/bitcoin/pubkey.c b/bitcoin/pubkey.c
@@ -83,7 +83,7 @@ char *fmt_secp256k1_pubkey(const tal_t *ctx, const secp256k1_pubkey *key)
 
 int pubkey_cmp(const struct pubkey *a, const struct pubkey *b)
 {
-	u8 keya[33], keyb[33];
+	u8 keya[PUBKEY_CMPR_LEN], keyb[PUBKEY_CMPR_LEN];
 	pubkey_to_der(keya, a);
 	pubkey_to_der(keyb, b);
 	return memcmp(keya, keyb, sizeof(keya));

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ char fmt_secp256k1_pubkey(const tal_t ctx, const secp256k1_pubkey *key)`
`83`	`83`
`84`	`84`	`int pubkey_cmp(const struct pubkey a, const struct pubkey b)`
`85`	`85`	`{`
`86`		`- u8 keya[33], keyb[33];`
	`86`	`+ u8 keya[PUBKEY_CMPR_LEN], keyb[PUBKEY_CMPR_LEN];`
`87`	`87`	`pubkey_to_der(keya, a);`
`88`	`88`	`pubkey_to_der(keyb, b);`
`89`	`89`	`return memcmp(keya, keyb, sizeof(keya));`