ci: Fix shellcheck warnings in coverage scripts

Address all shellcheck linting warnings:
- SC2207: Replace array assignment with mapfile -t
- SC2086: Add quotes to prevent word splitting
- SC2064: Use single quotes in trap command
- SC2004: Remove unnecessary ${} in arithmetic contexts

All scripts now pass shellcheck validation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

Author: cdecker

contrib/coverage/cleanup-corrupt-profraw.sh

@@ -12,7 +12,7 @@ fi
 echo "Scanning for corrupt profraw files in: $COVERAGE_DIR"
 
 # Find all profraw files
-PROFRAW_FILES=($(find "$COVERAGE_DIR" -name "*.profraw" 2>/dev/null || true))
+mapfile -t PROFRAW_FILES < <(find "$COVERAGE_DIR" -name "*.profraw" 2>/dev/null || true)
 
 if [ ${#PROFRAW_FILES[@]} -eq 0 ]; then
     echo "No .profraw files found"

contrib/coverage/collect-coverage.sh

@@ -8,7 +8,7 @@ OUTPUT="${2:-coverage/merged.profdata}"
 echo "Collecting coverage from: $COVERAGE_DIR"
 
 # Find all profraw files
-PROFRAW_FILES=($(find "$COVERAGE_DIR" -name "*.profraw" 2>/dev/null || true))
+mapfile -t PROFRAW_FILES < <(find "$COVERAGE_DIR" -name "*.profraw" 2>/dev/null || true)
 
 if [ ${#PROFRAW_FILES[@]} -eq 0 ]; then
     echo "ERROR: No .profraw files found in $COVERAGE_DIR"
@@ -75,7 +75,7 @@ mkdir -p "$(dirname "$OUTPUT")"
 BATCH_SIZE=500
 TOTAL_FILES=${#VALID_FILES[@]}
 
-if [ $TOTAL_FILES -le $BATCH_SIZE ]; then
+if [ "$TOTAL_FILES" -le "$BATCH_SIZE" ]; then
     # Small enough to merge in one go
     echo "Merging ${TOTAL_FILES} files..."
     llvm-profdata merge -sparse "${VALID_FILES[@]}" -o "$OUTPUT"
@@ -85,16 +85,16 @@ else
 
     # Create temp directory for intermediate files
     TEMP_DIR=$(mktemp -d "${TMPDIR:-/tmp}/profdata-merge.XXXXXX")
-    trap "rm -rf '$TEMP_DIR'" EXIT
+    trap 'rm -rf "$TEMP_DIR"' EXIT
 
     BATCH_NUM=0
     INTERMEDIATE_FILES=()
 
     # Merge files in batches
-    for ((i=0; i<$TOTAL_FILES; i+=$BATCH_SIZE)); do
+    for ((i=0; i<TOTAL_FILES; i+=BATCH_SIZE)); do
         BATCH_NUM=$((BATCH_NUM + 1))
         END=$((i + BATCH_SIZE))
-        if [ $END -gt $TOTAL_FILES ]; then
+        if [ "$END" -gt "$TOTAL_FILES" ]; then
             END=$TOTAL_FILES
         fi
 

contrib/coverage/generate-coverage-report.sh

@@ -13,8 +13,8 @@ fi
 
 # Get all binaries from Makefile (includes plugins, tools, test binaries)
 echo "Discovering instrumented binaries from Makefile..."
-BINARIES=($(make -qp 2>/dev/null | awk '/^ALL_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$'))
-TEST_BINARIES=($(make -qp 2>/dev/null | awk '/^ALL_TEST_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$'))
+mapfile -t BINARIES < <(make -qp 2>/dev/null | awk '/^ALL_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$')
+mapfile -t TEST_BINARIES < <(make -qp 2>/dev/null | awk '/^ALL_TEST_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$')
 
 # Combine all binaries
 ALL_BINARIES=("${BINARIES[@]}" "${TEST_BINARIES[@]}")

contrib/coverage/per-test-coverage-html.sh

@@ -13,8 +13,8 @@ fi
 
 # Get all binaries from Makefile (includes plugins, tools, test binaries)
 echo "Discovering instrumented binaries from Makefile..."
-BINARIES=($(make -qp 2>/dev/null | awk '/^ALL_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$'))
-TEST_BINARIES=($(make -qp 2>/dev/null | awk '/^ALL_TEST_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$'))
+mapfile -t BINARIES < <(make -qp 2>/dev/null | awk '/^ALL_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$')
+mapfile -t TEST_BINARIES < <(make -qp 2>/dev/null | awk '/^ALL_TEST_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$')
 
 # Combine all binaries
 ALL_BINARIES=("${BINARIES[@]}" "${TEST_BINARIES[@]}")
@@ -38,7 +38,7 @@ if [ ${#ARGS[@]} -eq 0 ]; then
 fi
 
 # Find all profdata files
-PROFDATA_FILES=($(find "$PROFDATA_DIR" -name "*.profdata" 2>/dev/null | sort))
+mapfile -t PROFDATA_FILES < <(find "$PROFDATA_DIR" -name "*.profdata" 2>/dev/null | sort)
 
 if [ ${#PROFDATA_FILES[@]} -eq 0 ]; then
     echo "ERROR: No .profdata files found in $PROFDATA_DIR"

contrib/coverage/per-test-coverage.sh

@@ -12,8 +12,8 @@ fi
 
 # Get all binaries from Makefile (includes plugins, tools, test binaries)
 echo "Discovering instrumented binaries from Makefile..."
-BINARIES=($(make -qp 2>/dev/null | awk '/^ALL_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$'))
-TEST_BINARIES=($(make -qp 2>/dev/null | awk '/^ALL_TEST_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$'))
+mapfile -t BINARIES < <(make -qp 2>/dev/null | awk '/^ALL_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$')
+mapfile -t TEST_BINARIES < <(make -qp 2>/dev/null | awk '/^ALL_TEST_PROGRAMS :=/ {$1=$2=""; print}' | tr ' ' '\n' | grep -v '^$')
 
 # Combine all binaries
 ALL_BINARIES=("${BINARIES[@]}" "${TEST_BINARIES[@]}")
@@ -39,7 +39,7 @@ fi
 mkdir -p "$OUTPUT_DIR"
 
 # Find all test subdirectories
-TEST_DIRS=($(find "$COVERAGE_DIR" -mindepth 1 -maxdepth 1 -type d 2>/dev/null | sort))
+mapfile -t TEST_DIRS < <(find "$COVERAGE_DIR" -mindepth 1 -maxdepth 1 -type d 2>/dev/null | sort)
 
 if [ ${#TEST_DIRS[@]} -eq 0 ]; then
     echo "ERROR: No test subdirectories found in $COVERAGE_DIR"
@@ -55,7 +55,7 @@ for test_dir in "${TEST_DIRS[@]}"; do
     echo -n "  $test_name... "
 
     # Find profraw files for this test
-    PROFRAW_FILES=($(find "$test_dir" -name "*.profraw" 2>/dev/null || true))
+    mapfile -t PROFRAW_FILES < <(find "$test_dir" -name "*.profraw" 2>/dev/null || true)
 
     if [ ${#PROFRAW_FILES[@]} -eq 0 ]; then
         echo "no profraw files"