pytest: test sql deprecated field (now we have one!).

Signed-off-by: Rusty Russell <[email protected]>

Author: rustyrussell

tests/test_plugin.py

@@ -4261,16 +4261,19 @@ def test_sql(node_factory, bitcoind):
 
 
 def test_sql_deprecated(node_factory, bitcoind):
-    # deprecated-apis breaks schemas...
-    l1 = node_factory.get_node(start=False, options={'allow-deprecated-apis': True})
-    l1.rpc.check_request_schemas = False
-    l1.start()
+    l1, l2 = node_factory.line_graph(2, opts=[{'allow-deprecated-apis': True}, {}])
+
+    # l1 allows it, l2 doesn't
+    ret = l1.rpc.sql("SELECT max_total_htlc_in_msat FROM peerchannels;")
+    assert ret == {'rows': [[-1]]}
 
-    # FIXME: we have no fields which have been deprecated since sql plugin was
-    # introduced.  When we do, add them here! (I manually tested a fake one)
+    # It's deprecated in l2, so that will fail!
+    with pytest.raises(RpcError, match="Deprecated column table peerchannels.max_total_htlc_in_msat"):
+        l2.rpc.sql("SELECT max_total_htlc_in_msat FROM peerchannels;")
 
-    #  ret = l1.rpc.sql("SELECT funding_local_msat, funding_remote_msat FROM peerchannels;")
-    #  assert ret == {'rows': []}
+    # But we can use a wildcard fine.
+    ret = l2.rpc.sql("SELECT COUNT(*) FROM peerchannels;")
+    assert ret == {'rows': [[1]]}
 
 
 def test_plugin_persist_option(node_factory):