lightningd: actually deprecate the listpeerchannels field.

Signed-off-by: Rusty Russell <[email protected]>

Author: rustyrussell

doc/developers-guide/deprecations.md

@@ -38,6 +38,7 @@ hidden: false
 | close.txid                           | Field              | v24.11           | v25.11         | Use txids array instead                                                                                                                |
 | experimental-offers                  | Config             | v24.11           | v25.05         | Now the default                                                                                                                        |
 | xpay.ignore_bolt12_mpp               | Field              | v25.05           | v25.11         | Try MPP even if the BOLT12 invoice doesn't explicitly allow it (CLN didn't until 25.02)                                                |
+| listpeerchannels.max_total_htlc_in_msat | Field           | v25.02           | v26.02         | Use our_max_total_htlc_out_msat                                                                                                              |
 
 Inevitably there are features which need to change: either to be generalized, or removed when they can no longer be supported.
 

lightningd/peer_control.c

@@ -1146,8 +1146,10 @@ static void NON_NULL_ARGS(1, 2, 4, 5) json_add_channel(struct command *cmd,
 	/* channel config */
 	json_add_amount_sat_msat(response, "dust_limit_msat",
 				 channel->our_config.dust_limit);
-	json_add_amount_msat(response, "max_total_htlc_in_msat",
-			     channel->our_config.max_htlc_value_in_flight);
+	if (command_deprecated_out_ok(cmd, "max_total_htlc_in_msat",
+				      "v25.02", "v26.02"))
+		json_add_amount_msat(response, "max_total_htlc_in_msat",
+				     channel->our_config.max_htlc_value_in_flight);
 	json_add_amount_msat(
 	    response, "their_max_htlc_value_in_flight_msat",
 	    channel->channel_info.their_config.max_htlc_value_in_flight);