lightningd: handle old Tor version 2 addresses in db without crashing.

In non-developer mode, this results in:

   "Could not load channels from the database"

Fixes: #5238
Signed-off-by: Rusty Russell <[email protected]>
Changelog-Fixed: lightningd: fix failed startup "Could not load channels from the database" if old TORv2 addresses were present.

Author: rustyrussell

CHANGELOG.md

@@ -17,12 +17,14 @@ which especially hurt larger nodes.
  - routing: Fixed an issue where we would exclude the entire channel if either direction was disabled, or we hadn't seen an update yet. ([#5286])
  - connectd: large memory usage with many peers fixed. ([#5312])
  - connectd: reduce initial CPU load when connecting to peers. ([#5328])
+ - lightnind: fix failed startup "Could not load channels from the database" if old TORv2 addresses were present. ([#5331])
 
 [#5286]: https://github.com/ElementsProject/lightning/pull/5286
 [#5300]: https://github.com/ElementsProject/lightning/pull/5300
 [#5312]: https://github.com/ElementsProject/lightning/pull/5312
 [#5326]: https://github.com/ElementsProject/lightning/pull/5326
 [#5328]: https://github.com/ElementsProject/lightning/pull/5328
+[#5331]: https://github.com/ElementsProject/lightning/pull/5331
 [0.11.2]: https://github.com/ElementsProject/lightning/releases/tag/v0.11.2
 
 ## [0.11.1] - 2022-05-13: Simon's Carefully Chosen Release Name II

wallet/wallet.c

@@ -836,10 +836,15 @@ static struct peer *wallet_peer_load(struct wallet *w, const u64 dbid)
 
 	db_col_node_id(stmt, "node_id", &id);
 
+	/* This can happen for peers last seen on Torv2! */
 	addrstr = db_col_strdup(tmpctx, stmt, "address");
 	if (!parse_wireaddr_internal(addrstr, &addr, DEFAULT_PORT,
-				     false, false, true, true, NULL))
-		goto done;
+				     false, false, true, true, NULL)) {
+		log_unusual(w->log, "Unparsable peer address %s: replacing",
+			    addrstr);
+		parse_wireaddr_internal("127.0.0.1:1", &addr, DEFAULT_PORT,
+					false, false, true, true, NULL);
+	}
 
 	/* FIXME: save incoming in db! */
 	peer = new_peer(w->ld, db_col_u64(stmt, "id"), &id, &addr, false);