ci: Mark some tests as rerun

Author: cdecker

pyproject.toml

@@ -30,7 +30,6 @@ dev = [
   "pytest-timeout>=2.4.0",
   "flake8>=7.0",
   "pytest-custom-exit-code==0.3.0",
-  "flaky>=3.7.0",
   "requests>=2.32.0",
   "flask-socketio>=5",
   "tqdm",

tests/test_coinmoves.py

@@ -681,6 +681,7 @@ def test_coinmoves_unilateral_htlc_before_included(node_factory, bitcoind):
     check_balances(l1, l2, fundchannel['channel_id'], 0)
 
 
+@pytest.mark.flaky(reruns=5)
 @pytest.mark.openchannel('v1')
 @pytest.mark.openchannel('v2')
 @unittest.skipIf(TEST_NETWORK != 'regtest', "Amounts are for regtest.")

tests/test_invoices.py

@@ -927,6 +927,7 @@ def test_invoices_wait_db_migration(node_factory, bitcoind):
 
 @unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "This test is based on a sqlite3 snapshot")
 @unittest.skipIf(TEST_NETWORK != 'regtest', "The DB migration is network specific due to the chain var.")
+@pytest.mark.flaky(reruns=5)
 def test_invoice_botched_migration(node_factory, chainparams):
     """Test for grubles' case, where they ran successfully with the wrong var: they have *both* last_invoice_created_index *and *last_invoices_created_index* (this can happen if invoice id 1 was deleted, so they didn't die on invoice creation):
     Error executing statement: wallet/db.c:1684: UPDATE vars SET name = 'last_invoices_created_index' WHERE name = 'last_invoice_created_index': UNIQUE constraint failed: vars.name

tests/test_plugin.py

@@ -2191,6 +2191,7 @@ def test_plugin_fail(node_factory):
     l1.daemon.wait_for_log(r': exited during normal operation')
 
 
+@pytest.mark.flaky(reruns=5)
 @pytest.mark.openchannel('v1')
 @pytest.mark.openchannel('v2')
 def test_coin_movement_notices(node_factory, bitcoind, chainparams):

tests/test_reckless.py

@@ -351,6 +351,7 @@ def test_tag_install(node_factory):
             header = line
 
 
+@pytest.mark.flaky(reruns=5)
 @unittest.skipIf(VALGRIND and SLOW_MACHINE, "node too slow for starting plugin under valgrind")
 def test_reckless_uv_install(node_factory):
     node = get_reckless_node(node_factory)

tests/test_splicing.py

@@ -499,6 +499,7 @@ def test_splice_stuck_htlc(node_factory, bitcoind, executor):
     assert l1.db_query("SELECT count(*) as c FROM channeltxs;")[0]['c'] == 0
 
 
+@pytest.mark.flaky(reruns=5)
 @unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
 def test_route_by_old_scid(node_factory, bitcoind):
     l1, l2, l3 = node_factory.line_graph(3, wait_for_announce=True, opts={'experimental-splicing': None, 'may_reconnect': True})