lightningd: no longer allow plugin flag options with non-false default values.

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Removed: default settings for flag options in plugins which aren't "false".

Author: rustyrussell

doc/developers-guide/deprecations.md

@@ -11,7 +11,6 @@ hidden: false
 | rest-protocol.clnrest-prefix         | Config             | v23.11           | v24.11         | Autodetect where we need to rename `rest-protocol` to `clnrest-protocol` (added in v23.11)                                                                                      |
 | rest-host.clnrest-prefix             | Config             | v23.11           | v24.11         | Autodetect where we need to rename `rest-host` to `clnrest-host` (added in v23.11)                                                                                              |
 | rest-certs.clnrest-prefix            | Config             | v23.11           | v24.11         | Autodetect where we need to rename `rest-certs` to `clnrest-certs` (added in v23.11)                                                                                            |
-| options.flag.default-not-false       | Getmanifest Reply  | v23.08           | v24.08         | `flag` options with a default which is not `false` (would be meaningless, since user can only set it to `true`                                                                  |
 | plugin.nonumericids                  | Getmanifest Reply  | v23.08           | v24.08         | Plugins must specify that they can accept non-numeric command ids (numeric ids are deprecated)                                                                                  |
 | listchannels.include_private         | Field(s)           | v24.02           | v24.08         | `listchannels` including private channels (now use listpeerchannels which gives far more detail)                                                                                |
 | max-locktime-blocks                  | Config             | v24.05           | v24.11         | --max-locktime-blocks is now set to 2016 in the BOLT 4 spec                                                                                                                     |

lightningd/plugin.c

@@ -1072,7 +1072,6 @@ static const char *plugin_opt_add(struct plugin *plugin, const char *buffer,
 	const char *name, *err;
 	enum opt_type optflags = 0;
 	bool set;
-	struct lightningd *ld = plugin->plugins->ld;
 
 	nametok = json_get_member(buffer, opt, "name");
 	typetok = json_get_member(buffer, opt, "type");
@@ -1134,15 +1133,10 @@ static const char *plugin_opt_add(struct plugin *plugin, const char *buffer,
 			/* We used to allow (ignore) anything, now make sure it's 'false' */
 			if (!json_to_bool(buffer, defaulttok, &val)
 			    || val != false) {
-				if (!lightningd_deprecated_in_ok(ld, plugin->log,
-								 ld->deprecated_ok,
-								 "options.flag", "default-not-false",
-								 "v23.08", "v24.08", NULL)) {
-					return tal_fmt(plugin, "%s type flag default must be 'false' not %.*s",
-						       popt->name,
-						       json_tok_full_len(defaulttok),
-						       json_tok_full(buffer, defaulttok));
-				}
+				return tal_fmt(plugin, "%s type flag default must be 'false' not %.*s",
+					       popt->name,
+					       json_tok_full_len(defaulttok),
+					       json_tok_full(buffer, defaulttok));
 			}
 			defaulttok = NULL;
 		}