wallet: wallet_get_addrtype should tell caller it has no info.

Turns out we don't actually use this, so easy to change the function.

Signed-off-by: Rusty Russell <[email protected]>

Author: rustyrussell

wallet/wallet.c

@@ -857,10 +857,10 @@ s64 wallet_get_newindex(struct lightningd *ld, enum addrtype addrtype)
 	return newidx;
 }
 
-enum addrtype wallet_get_addrtype(struct wallet *wallet, u64 idx)
+bool wallet_get_addrtype(struct wallet *wallet, u64 idx,
+			 enum addrtype *addrtype)
 {
 	struct db_stmt *stmt;
-	enum addrtype type;
 
 	stmt = db_prepare_v2(wallet->db,
 			     SQL("SELECT addrtype"
@@ -872,12 +872,12 @@ enum addrtype wallet_get_addrtype(struct wallet *wallet, u64 idx)
 	/* Unknown means prior to v24.11 */
 	if (!db_step(stmt)) {
 		tal_free(stmt);
-		return ADDR_P2TR|ADDR_BECH32;
+		return false;
 	}
 
-	type = wallet_addrtype_in_db(db_col_int(stmt, "addrtype"));
+	*addrtype = wallet_addrtype_in_db(db_col_int(stmt, "addrtype"));
 	tal_free(stmt);
-	return type;
+	return true;
 }
 
 static void wallet_shachain_init(struct wallet *wallet,

wallet/wallet.h

@@ -606,8 +606,12 @@ s64 wallet_get_newindex(struct lightningd *ld, enum addrtype addrtype);
  * wallet_get_addrtype - get the address types for this key.
  * @wallet: (in) wallet
  * @keyidx: what address types we've published.
+ * @addrtype: filled in if true.
+ *
+ * If we don't know, returns false.
  */
-enum addrtype wallet_get_addrtype(struct wallet *w, u64 keyidx);
+bool wallet_get_addrtype(struct wallet *wallet, u64 idx,
+			 enum addrtype *addrtype);
 
 /**
  * wallet_shachain_add_hash -- wallet wrapper around shachain_add_hash