ci: Mark some tests as rerun

Author: cdecker

pyproject.toml

@@ -30,7 +30,6 @@ dev = [
   "pytest-timeout>=2.4.0",
   "flake8>=7.0",
   "pytest-custom-exit-code==0.3.0",
-  "flaky>=3.7.0",
   "requests>=2.32.0",
   "flask-socketio>=5",
   "tqdm",

tests/test_invoices.py

@@ -927,6 +927,7 @@ def test_invoices_wait_db_migration(node_factory, bitcoind):
 
 @unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "This test is based on a sqlite3 snapshot")
 @unittest.skipIf(TEST_NETWORK != 'regtest', "The DB migration is network specific due to the chain var.")
+@pytest.mark.flaky(reruns=5)
 def test_invoice_botched_migration(node_factory, chainparams):
     """Test for grubles' case, where they ran successfully with the wrong var: they have *both* last_invoice_created_index *and *last_invoices_created_index* (this can happen if invoice id 1 was deleted, so they didn't die on invoice creation):
     Error executing statement: wallet/db.c:1684: UPDATE vars SET name = 'last_invoices_created_index' WHERE name = 'last_invoice_created_index': UNIQUE constraint failed: vars.name