offers: don't call create_invoicereq twice.

rustyrussell · rustyrussell · commit e271f35a44cb · 2025-02-14T20:59:42.000+10:30
We ignored the second one, but still it's unnecessary.

Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
diff --git a/plugins/offers_invreq_hook.c b/plugins/offers_invreq_hook.c
@@ -353,7 +353,7 @@ static struct command_result *add_blindedpaths(struct command *cmd,
 					       struct invreq *ir)
 {
 	if (!we_want_blinded_path(cmd->plugin))
-		create_invoicereq(cmd, ir);
+		return create_invoicereq(cmd, ir);
 
 	return find_best_peer(cmd, OPT_ROUTE_BLINDING,
 			      found_best_peer, ir);

Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,7 @@ static struct command_result add_blindedpaths(struct command cmd,`
`353`	`353`	`struct invreq *ir)`
`354`	`354`	`{`
`355`	`355`	`if (!we_want_blinded_path(cmd->plugin))`
`356`		`- create_invoicereq(cmd, ir);`
	`356`	`+ return create_invoicereq(cmd, ir);`
`357`	`357`
`358`	`358`	`return find_best_peer(cmd, OPT_ROUTE_BLINDING,`
`359`	`359`	`found_best_peer, ir);`