libplugin: correctly mark that plugin_notification_end STEALS the stream.

And also slightly generalize: plugin_notification_start() can take any
tal ptr.

Signed-off-by: Rusty Russell <[email protected]>

Author: rustyrussell

plugins/libplugin.c

@@ -1859,10 +1859,10 @@ void plugin_gossmap_logcb(struct plugin *plugin,
 	va_end(ap);
 }
 
-struct json_stream *plugin_notification_start(struct plugin *plugin,
+struct json_stream *plugin_notification_start(const tal_t *ctx,
 					      const char *method)
 {
-	struct json_stream *js = new_json_stream(plugin, NULL, NULL);
+	struct json_stream *js = new_json_stream(ctx, NULL, NULL);
 
 	json_object_start(js, NULL);
 	json_add_string(js, "jsonrpc", "2.0");
@@ -1873,7 +1873,7 @@ struct json_stream *plugin_notification_start(struct plugin *plugin,
 }
 
 void plugin_notification_end(struct plugin *plugin,
-			     struct json_stream *stream)
+			     struct json_stream *stream STEALS)
 {
 	json_object_end(stream);
 	jsonrpc_finish_and_send(plugin, stream);

plugins/libplugin.h

@@ -534,10 +534,10 @@ void plugin_notify_end(struct command *cmd, struct json_stream *js);
 
 /* Send a notification for a custom notification topic. These are sent
  * to lightningd and distributed to subscribing plugins. */
-struct json_stream *plugin_notification_start(struct plugin *plugins,
+struct json_stream *plugin_notification_start(const tal_t *ctx,
 					      const char *method);
 void plugin_notification_end(struct plugin *plugin,
-			     struct json_stream *stream TAKES);
+			     struct json_stream *stream STEALS);
 
 /* Convenience wrapper for notify "message" */
 void plugin_notify_message(struct command *cmd,

plugins/test/run-route-calc.c

@@ -299,10 +299,10 @@ void plugin_log(struct plugin *p UNNEEDED, enum log_level l UNNEEDED, const char
 { fprintf(stderr, "plugin_log called!\n"); abort(); }
 /* Generated stub for plugin_notification_end */
 void plugin_notification_end(struct plugin *plugin UNNEEDED,
-			     struct json_stream *stream TAKES UNNEEDED)
+			     struct json_stream *stream STEALS UNNEEDED)
 { fprintf(stderr, "plugin_notification_end called!\n"); abort(); }
 /* Generated stub for plugin_notification_start */
-struct json_stream *plugin_notification_start(struct plugin *plugins UNNEEDED,
+struct json_stream *plugin_notification_start(const tal_t *ctx UNNEEDED,
 					      const char *method UNNEEDED)
 { fprintf(stderr, "plugin_notification_start called!\n"); abort(); }
 /* Generated stub for plugin_notify_message */

plugins/test/run-route-overlong.c

@@ -296,10 +296,10 @@ void plugin_log(struct plugin *p UNNEEDED, enum log_level l UNNEEDED, const char
 { fprintf(stderr, "plugin_log called!\n"); abort(); }
 /* Generated stub for plugin_notification_end */
 void plugin_notification_end(struct plugin *plugin UNNEEDED,
-			     struct json_stream *stream TAKES UNNEEDED)
+			     struct json_stream *stream STEALS UNNEEDED)
 { fprintf(stderr, "plugin_notification_end called!\n"); abort(); }
 /* Generated stub for plugin_notification_start */
-struct json_stream *plugin_notification_start(struct plugin *plugins UNNEEDED,
+struct json_stream *plugin_notification_start(const tal_t *ctx UNNEEDED,
 					      const char *method UNNEEDED)
 { fprintf(stderr, "plugin_notification_start called!\n"); abort(); }
 /* Generated stub for plugin_notify_message */