lightningd: save funding PSBT to database if we're to withhold it.

Normally we don't care, but if we're withholding it, keep it around
so we can sign & broadcast later.

Signed-off-by: Rusty Russell <[email protected]>

Author: rustyrussell

lightningd/channel.c

@@ -436,6 +436,7 @@ struct channel *new_unsaved_channel(struct peer *peer,
 	channel->channel_gossip = NULL;
 	channel->forgets = tal_arr(channel, struct command *, 0);
 	channel->funding_psbt = NULL;
+	channel->withheld = false;
 	list_add_tail(&peer->channels, &channel->list);
 	channel->rr_number = peer->ld->rr_counter++;
 	tal_add_destructor(channel, destroy_channel);
@@ -558,7 +559,8 @@ struct channel *new_channel(struct peer *peer, u64 dbid,
 			    u64 last_stable_connection,
 			    const struct channel_stats *stats,
 			    struct channel_state_change **state_changes STEALS,
-			    const struct wally_psbt *funding_psbt STEALS)
+			    const struct wally_psbt *funding_psbt STEALS,
+			    bool withheld)
 {
 	struct channel *channel = tal(peer->ld, struct channel);
 	struct amount_msat htlc_min, htlc_max;
@@ -735,6 +737,7 @@ struct channel *new_channel(struct peer *peer, u64 dbid,
 						 &channel->cid,
 						 "We can't be together anymore.");
 	channel->funding_psbt = tal_steal(channel, funding_psbt);
+	channel->withheld = withheld;
 	return channel;
 }
 

lightningd/channel.h

@@ -359,6 +359,9 @@ struct channel {
 
 	/* Unsigned PSBT if we initiated the open channel */
 	const struct wally_psbt *funding_psbt;
+
+	/* Are we not broadcasting the open tx? */
+	bool withheld;
 };
 
 /* Is channel owned (and should be talking to peer) */
@@ -445,7 +448,8 @@ struct channel *new_channel(struct peer *peer, u64 dbid,
 			    u64 last_stable_connection,
 			    const struct channel_stats *stats,
 			    struct channel_state_change **state_changes STEALS,
-			    const struct wally_psbt *funding_psbt STEALS);
+			    const struct wally_psbt *funding_psbt STEALS,
+			    bool withheld);
 
 /* new_inflight - Create a new channel_inflight for a channel */
 struct channel_inflight *new_inflight(struct channel *channel,

lightningd/closed_channel.h

@@ -31,6 +31,7 @@ struct closed_channel {
 	/* NULL for older closed channels */
 	const struct shachain *their_shachain;
 	const struct wally_psbt *funding_psbt;
+	bool withheld;
 };
 
 static inline const struct channel_id *keyof_closed_channel(const struct closed_channel *cc)

lightningd/opening_common.h

@@ -104,6 +104,9 @@ struct funding_channel {
 
 	/* Were we the one to publish the commitment/splicing tx? */
 	const struct wally_psbt *funding_psbt;
+
+	/* Were we told to withhold the commitment tx? */
+	bool withheld;
 };
 
 struct uncommitted_channel *new_uncommitted_channel(struct peer *peer);

lightningd/opening_control.c

@@ -97,7 +97,8 @@ wallet_commit_channel(struct lightningd *ld,
 		      const u8 *our_upfront_shutdown_script,
 		      const u8 *remote_upfront_shutdown_script,
 		      const struct channel_type *type,
-		      const struct wally_psbt *funding_psbt)
+		      const struct wally_psbt *funding_psbt,
+		      bool withheld)
 {
 	struct channel *channel;
 	struct amount_msat our_msat;
@@ -237,7 +238,8 @@ wallet_commit_channel(struct lightningd *ld,
 			      0,
 			      &zero_channel_stats,
 			      tal_arr(NULL, struct channel_state_change *, 0),
-			      funding_psbt);
+			      funding_psbt,
+			      withheld);
 
 	/* Now we finally put it in the database. */
 	wallet_channel_insert(ld->wallet, channel);
@@ -446,7 +448,8 @@ static void opening_funder_finished(struct subd *openingd, const u8 *resp,
 					fc->our_upfront_shutdown_script,
 					remote_upfront_shutdown_script,
 					type,
-					fc->funding_psbt);
+					fc->funding_psbt,
+					fc->withheld);
 	if (!channel) {
 		was_pending(command_fail(fc->cmd, LIGHTNINGD,
 					 "Key generation failure"));
@@ -550,7 +553,8 @@ static void opening_fundee_finished(struct subd *openingd,
 					local_upfront_shutdown_script,
 					remote_upfront_shutdown_script,
 					type,
-					NULL);
+					NULL,
+					false);
 	if (!channel) {
 		uncommitted_channel_disconnect(uc, LOG_BROKEN,
 					       "Commit channel failed");
@@ -1096,6 +1100,9 @@ static struct command_result *json_fundchannel_complete(struct command *cmd,
 
 	fc->funding_psbt = tal_steal(fc, funding_psbt);
 
+	/* FIXME: Set by option */
+	fc->withheld = false;
+
 	/* Set the cmd to this new cmd */
 	peer->uncommitted_channel->fc->cmd = cmd;
 	msg = towire_openingd_funder_complete(NULL,
@@ -1644,7 +1651,8 @@ static struct channel *stub_chan(struct command *cmd,
 			      0,
 			      &zero_channel_stats,
 			      tal_arr(NULL, struct channel_state_change *, 0),
-			      NULL);
+			      NULL,
+			      false);
 
 	/* We don't want to gossip about this, ever. */
 	channel->channel_gossip = tal_free(channel->channel_gossip);

wallet/db.c

@@ -1101,6 +1101,7 @@ static struct migration dbmigrations[] = {
 	 " PRIMARY KEY (id)"
 	 ")"), NULL},
     {NULL, migrate_fail_pending_payments_without_htlcs},
+    {SQL("ALTER TABLE channels ADD withheld INTEGER DEFAULT 0;"), NULL},
 };
 
 /**

wallet/test/run-chain_moves_duplicate-detect.c

@@ -235,7 +235,8 @@ struct channel *new_channel(struct peer *peer UNNEEDED, u64 dbid UNNEEDED,
 			    u64 last_stable_connection UNNEEDED,
 			    const struct channel_stats *stats UNNEEDED,
 			    struct channel_state_change **state_changes STEALS UNNEEDED,
-			    const struct wally_psbt *funding_psbt STEALS UNNEEDED)
+			    const struct wally_psbt *funding_psbt STEALS UNNEEDED,
+			    bool withheld UNNEEDED)
 { fprintf(stderr, "new_channel called!\n"); abort(); }
 /* Generated stub for new_channel_state_change */
 struct channel_state_change *new_channel_state_change(const tal_t *ctx UNNEEDED,

wallet/test/run-db.c

@@ -243,7 +243,8 @@ struct channel *new_channel(struct peer *peer UNNEEDED, u64 dbid UNNEEDED,
 			    u64 last_stable_connection UNNEEDED,
 			    const struct channel_stats *stats UNNEEDED,
 			    struct channel_state_change **state_changes STEALS UNNEEDED,
-			    const struct wally_psbt *funding_psbt STEALS UNNEEDED)
+			    const struct wally_psbt *funding_psbt STEALS UNNEEDED,
+			    bool withheld UNNEEDED)
 { fprintf(stderr, "new_channel called!\n"); abort(); }
 /* Generated stub for new_channel_state_change */
 struct channel_state_change *new_channel_state_change(const tal_t *ctx UNNEEDED,

wallet/test/run-migrate_remove_chain_moves_duplicates.c

@@ -250,7 +250,8 @@ struct channel *new_channel(struct peer *peer UNNEEDED, u64 dbid UNNEEDED,
 			    u64 last_stable_connection UNNEEDED,
 			    const struct channel_stats *stats UNNEEDED,
 			    struct channel_state_change **state_changes STEALS UNNEEDED,
-			    const struct wally_psbt *funding_psbt STEALS UNNEEDED)
+			    const struct wally_psbt *funding_psbt STEALS UNNEEDED,
+			    bool withheld UNNEEDED)
 { fprintf(stderr, "new_channel called!\n"); abort(); }
 /* Generated stub for new_channel_state_change */
 struct channel_state_change *new_channel_state_change(const tal_t *ctx UNNEEDED,

wallet/test/run-wallet.c

@@ -1625,7 +1625,8 @@ static bool test_channel_inflight_crud(struct lightningd *ld, const tal_t *ctx)
 			   0,
 			   stats,
 			   tal_arr(NULL, struct channel_state_change *, 0),
-			   NULL);
+			   NULL,
+			   false);
 	db_begin_transaction(w->db);
 	CHECK(!wallet_err);
 	wallet_channel_insert(w, chan);