From 6c564e2c30684f1d8284d0b045afbd0ba1c9750f Mon Sep 17 00:00:00 2001 From: Alex Myers Date: Fri, 4 Oct 2024 11:25:20 -0500 Subject: [PATCH] gossipd: drive-by correction of new channel announcement evaluation According to the description, we should be checking the existence of a channel update on the other side here. Changelog-None --- gossipd/gossmap_manage.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gossipd/gossmap_manage.c b/gossipd/gossmap_manage.c index 6ebf05f1db4f..379851be6a75 100644 --- a/gossipd/gossmap_manage.c +++ b/gossipd/gossmap_manage.c @@ -618,7 +618,7 @@ void gossmap_manage_handle_get_txout_reply(struct gossmap_manage *gm, const u8 * pca = map_del(&gm->pending_ann_map, scid); if (!pca) { - /* If we looking specifically for this, we no longer + /* If we were looking specifically for this, we no longer * are (but don't penalize sender: we don't know if it was * good or bad). */ remove_unknown_scid(gm->daemon->seeker, &scid, true); @@ -703,7 +703,7 @@ void gossmap_manage_handle_get_txout_reply(struct gossmap_manage *gm, const u8 * txout_failures_add(gm->txf, scid); out: tal_free(pca); - /* If we looking specifically for this, we no longer are. */ + /* If we were looking specifically for this, we no longer are. */ remove_unknown_scid(gm->daemon->seeker, &scid, false); } @@ -773,7 +773,7 @@ static const char *process_channel_update(const tal_t *ctx, } else { /* Is this the first update in either direction? If so, * rewrite channel_announcement so timestamp is correct. */ - if (!gossmap_chan_set(chan, dir)) + if (!gossmap_chan_set(chan, !dir)) gossip_store_set_timestamp(gm->daemon->gs, chan->cann_off, timestamp); }