Skip to content

Conversation

@Lagrang3
Copy link
Collaborator

@Lagrang3 Lagrang3 commented Dec 11, 2024

Add log information about the runtime of getroutes in the form

get_routes completed in X ms

Is this proper naming?
The string should have a unique signature to be able to extract it with regex patterns.

@Lagrang3
Copy link
Collaborator Author

Putting this into draft. As I am thinking we could do more than runtime statistics and even broadcast these values
in a "message" to listening plugins.

@Lagrang3 Lagrang3 marked this pull request as draft December 12, 2024 20:35
@Lagrang3 Lagrang3 force-pushed the askrene-measure-time branch from 9246744 to 1e27620 Compare March 12, 2025 09:04
@Lagrang3 Lagrang3 marked this pull request as ready for review March 12, 2025 09:04
@Lagrang3 Lagrang3 force-pushed the askrene-measure-time branch from 1e27620 to 7e173e2 Compare March 12, 2025 11:15
@Lagrang3 Lagrang3 force-pushed the askrene-measure-time branch from 7e173e2 to 4a840c2 Compare March 24, 2025 07:02
@Lagrang3 Lagrang3 requested a review from rustyrussell March 25, 2025 11:03
@Lagrang3 Lagrang3 force-pushed the askrene-measure-time branch from 4a840c2 to 2314e1c Compare April 30, 2025 10:44
@Lagrang3 Lagrang3 force-pushed the askrene-measure-time branch from 2314e1c to e32f2ca Compare May 19, 2025 05:21
@Lagrang3 Lagrang3 added this to the v25.08 milestone May 19, 2025
@Lagrang3 Lagrang3 mentioned this pull request May 19, 2025
3 tasks
Add log information about the runtime of getroutes.

Changelog-None: askrene: add runtime of getroutes to the logs

Signed-off-by: Lagrang3 <[email protected]>
@rustyrussell rustyrussell force-pushed the askrene-measure-time branch from e32f2ca to ad71604 Compare July 8, 2025 03:15
@rustyrussell rustyrussell enabled auto-merge (rebase) July 8, 2025 03:15
@rustyrussell rustyrussell merged commit 266a5f9 into ElementsProject:master Jul 10, 2025
76 of 78 checks passed
@Lagrang3 Lagrang3 deleted the askrene-measure-time branch July 11, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants