Wallet can spend takes ages #8019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/wallet-can-spend-takes-ages
branch
from
1e0f9cd to
99ecd13
Compare
rustyrussell
force-pushed
the
guilt/wallet-can-spend-takes-ages
branch
from
0689086 to
a8f1b8a
Compare
…sses.
From Whitslack's "startup takes 15 minutes" bug report, we can see
that wallet_can_spend is extremely slow. We exacerbate this by setting a large
bip32_max_index:
```
91.29% 0.02% lightningd lightningd [.] wallet_can_spend
|
--91.27%--wallet_can_spend
|
|--47.81%--scriptpubkey_p2tr_derkey
| |
| |--42.80%--scriptpubkey_p2tr
...
|--42.16%--bip32_key_from_parent
```
Signed-off-by: Rusty Russell <[email protected]>
It was long obsoleted, and never appears in the DB, but we do still have to handle old ones in the code. We removed it from the enum in f342630 (v24.02) after deprecating it in 23.02. Signed-off-by: Rusty Russell <[email protected]>
Turns out we don't actually use this, so easy to change the function. Signed-off-by: Rusty Russell <[email protected]>
For now we don't actually update it; that's next patch. Signed-off-by: Rusty Russell <[email protected]>
On lookup, we update the htable if any new addresses have been added. Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: lightningd: startup time vastly improved for large nodes with pending closes and many bitcoin addresses.
rustyrussell
force-pushed
the
guilt/wallet-can-spend-takes-ages
branch
from
a8f1b8a to
481a247
Compare
As I suspected, benchmark tests like this are too unreliable under CI. Signed-off-by: Rusty Russell <[email protected]>
endothermicdev
force-pushed
the
guilt/wallet-can-spend-takes-ages
branch
from
cec8d01 to
f1c2ef3
Compare
Collaborator
|
That's a shame about removing the test, it seems like it ran fine 90% of the time, but apparently there's a long tail in the distribution of outcomes under CI. |
endothermicdev
merged commit df24568
into
ElementsProject:master
39 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8014