From 6f11f4f250a3ef3678f2908e343c2c2cf40450b2 Mon Sep 17 00:00:00 2001 From: Matt Whitlock Date: Sun, 17 Aug 2025 03:46:50 -0400 Subject: [PATCH] connectd: demote "Peer did not close, forcing close" to UNUSUAL This message is logged when connectd tries to shut down a peer connection but the transmit buffer remains full for too long, maybe because the peer has crashed or has lost connectivity. Logging this message at the BROKEN level is inappropriate because BROKEN is intended to flag logic errors that imply incorrect code in CLN. The error in question here is actually a runtime error, which does not imply incorrect code (at least on our side), so demote the log message to the UNUSUAL level. (Even this is still probably too severe, as this message is logged rather more frequently than "unusual" would suggest.) Changelog-None Closes: https://github.com/ElementsProject/lightning/issues/5678 --- connectd/multiplex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connectd/multiplex.c b/connectd/multiplex.c index 49eccbb3d4cc..d0586c0d6bd5 100644 --- a/connectd/multiplex.c +++ b/connectd/multiplex.c @@ -107,7 +107,7 @@ static void maybe_free_peer(struct peer *peer) static void close_peer_io_timeout(struct peer *peer) { /* BROKEN means we'll trigger CI if we see it, though it's possible */ - status_peer_broken(&peer->id, "Peer did not close, forcing close"); + status_peer_unusual(&peer->id, "Peer did not close, forcing close"); io_close(peer->to_peer); }