Skip to content

fuzz-tests: Make fuzz-bolt12-offer-decode roundrip #8637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Chand-ra wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fuzz-tests: Make fuzz-bolt12-offer-decode roundrip #8637

Chand-ra wants to merge 2 commits into from
+187 −3

Conversation

@Chand-ra
Copy link

@Chand-ra Chand-ra commented Oct 27, 2025 •
edited
Loading

Changelog-None: Currently, the BOLT #12 offer parsing test only tests the offer decoding function. Add a test for the encoding function as well by making the test roundtrip.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

@Chand-ra Chand-ra force-pushed the bolt12-offer branch 2 times, most recently from 5f4fbb7 to 3fbc885 Compare October 29, 2025 17:55
@madelinevibes
Copy link
Collaborator

madelinevibes commented Dec 8, 2025 •
edited
Loading

HI @Chand-ra it seems this one got lost for 25.12, is there an open issue that this PR solves? or if just for CI.
I have added it to the milestone for our release early 2025. It will need to be reviewed still!!

@madelinevibes madelinevibes added this to the v26.03 milestone Dec 8, 2025
@Chand-ra
Copy link
Author

Chand-ra commented Dec 8, 2025

HI @Chand-ra it seems this one got lost for 25.12, is there an open issue that this PR solves? or if just for CI.

Hey @madelinevibes, no this PR does not address any open issue.

It is an improvement to an existing fuzz test and is meant to better help in catching regressions in the future. So yes, I suppose it is 'just for CI'.

I have added it to the milestone for our release early 2025. It will need to be reviewed still!!

Makes sense.

@madelinevibes
Copy link
Collaborator

madelinevibes commented Dec 8, 2025

HI @Chand-ra it seems this one got lost for 25.12, is there an open issue that this PR solves? or if just for CI.

Hey @madelinevibes, no this PR does not address any open issue.

It is an improvement to an existing fuzz test and is meant to better help in catching regressions in the future. So yes, I suppose it is 'just for CI'.

I have added it to the milestone for our release early 2025. It will need to be reviewed still!!

Makes sense.

great, thanks! can you please rebase before we review?

Chandra Pratap added 2 commits December 9, 2025 05:58
fuzz-tests: Make fuzz-bolt12-offer-decode roundrip
b3df4e7 
Changelog-None: Currently, the `BOLT ElementsProject#12` offer parsing test only
tests the offer decode function. Add a test for the encoding
function as well by making the test roundtrip.
fuzz-tests: Add coverage increasing inputs to seed corpora
751c4b6 
Improvements in the fuzz-testing scheme of
`fuzz-bolt12-offer-decode` led to the discovery of test inputs
that result in greater in code coverage.

Add these inputs to the test's seed corpus.
@Chand-ra
Copy link
Author

Chand-ra commented Dec 9, 2025

great, thanks! can you please rebase before we review?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-rebase

Projects

None yet

Milestone

v26.04

Development

Successfully merging this pull request may close these issues.

2 participants

@Chand-ra @madelinevibes