Skip to content

Commit 67038cd

Browse files
committed
Retest only gix-path, not gix-testtools
`gix-testtools` currently uses a hard-coded `GIT_PROGRAM` value of `git.exe` on Windows. `gix-testtools` uses `GIT_PROGRAM` directly in `GIT_CORE_DIR`, `parse_git_version`, `run_git`, and `populate_meta_dir`, as well as in its own test case `configure_command_clears_external_config`. When the path `git.exe` cannot be used to execute the `git` program, these `gix-testtools` tests fail in `test-fast` on `ubuntu-latest`: - tests::bash_program_absolute_or_unrooted - tests::bash_program_ok_for_platform - tests::bash_program_unix_path - tests::configure_command_clears_external_config Various other functionality of `gix-testtools` is also likely to fail. `gix-testtools` will have to be fixed to work with this, probably by causing it to use facilities provided by `gix-path`, as discussed in GitoxideLabs#1992 comments, in GitoxideLabs#1886, and elsewhere. (Those discussions are with a focus on finding shells through `git`, rather than finding `git` itself. But using `gix-path` facilities in `gix-testtools` should be able to solve both, for when the `git` executable can be found on Windows but not in a `PATH` search for `git.exe`.) But let's see if we can already successfully rerun the `gix-path` tests with `git.exe` not in `PATH`. This removes the step to retest `gix-testtools`, for now. This is with the idea that if rerunning `gix-path` tests works in the `test-fast` job on `windows-latest` and the tests pass there but some fail on `windows-11-arm`, then they will have surfaced bugs affecting our use of ARM64 builds of Git for Windows that can be fixed even *before* `gix-testtools` is modified to use more `gix-path` facilities to find `git` and associated executables.
1 parent 3fab6d9 commit 67038cd

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,6 @@ jobs:
252252
- name: Retest gix-path without `git` in `PATH` (nextest)
253253
if: startsWith(matrix.os, 'windows')
254254
run: cargo nextest run -p gix-path --no-fail-fast -- ${{ matrix.text-args }}
255-
- name: Retest gix-testtools
256-
if: startsWith(matrix.os, 'windows')
257-
run: cargo nextest run -p gix-testtools --no-fail-fast -- ${{ matrix.test-args }}
258255

259256
test-fixtures-windows:
260257
strategy:

0 commit comments

Comments
 (0)