Abandon winget idea; start on upgrading GfW the old way

So far this only attempts to upgrade it for `test-fast` because
whatever is going to go wrong may as well be fixed for that before
extending it to `test-fixtures-windows`.

The approach followed here is similar to what was done in the past,
but some specific details differ, including trying to make it work
for both ARM64 and x64 systems and putting everything in a single
step rather than three steps.

Author: EliahKagan

.github/workflows/ci.yml

@@ -254,12 +254,44 @@ jobs:
     runs-on: ${{ matrix.os }}
 
     steps:
-      - name: Set up WinGet
-        if: matrix.os == 'windows-11-arm'
-        run: Add-AppxPackage -RegisterByFamilyName -MainPackage Microsoft.DesktopAppInstaller_8wekyb3d8bbwe
-      - name: Upgrade Git for Windows
+      - name: Upgrade Git for Windows to latest stable release
         if: startsWith(matrix.os, 'windows')
-        run: winget upgrade git --silent --accept-source-agreements --accept-package-agreements
+        env:
+          GH_TOKEN: ${{ github.token }}
+          OS: ${{ matrix.os }}
+        run: |
+          $workingDir = '~/git-dl'
+          $repo = 'git-for-windows/git'
+          $pattern = ($Env:OS -eq 'windows-11-arm' ? 'Git-*-arm64.exe' : 'Git-*-64-bit.exe')
+          $log = 'setup-log.txt'
+          # Inno Setup args reference: https://jrsoftware.org/ishelp/index.php?topic=setupcmdline
+          $arguments = @(
+            '/VERYSILENT',
+            '/SUPPRESSMSGBOXES',
+            '/ALLUSERS',
+            "/LOG=$log",
+            '/NORESTART',
+            '/CLOSEAPPLICATIONS',
+            '/FORCECLOSEAPPLICATIONS'
+          )
+
+          Write-Output 'Version and build information BEFORE upgrade:'
+          Write-Output ''
+          git version --build-options
+          Write-Output ''
+
+          mkdir $workingDir | Out-Null
+          cd $workingDir
+          gh release download --repo $repo --pattern $pattern
+          $installer = Get-Item $pattern
+          Start-Process -FilePath $installer -ArgumentList $arguments -NoNewWindow -Wait
+
+          Get-Content -Path $log -Tail 50
+
+          Write-Output ''
+          Write-Output 'Version and build information AFTER upgrade:'
+          Write-Output ''
+          git version --build-options
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false
@@ -329,11 +361,6 @@ jobs:
     runs-on: ${{ matrix.os }}
 
     steps:
-      - name: Set up WinGet
-        if: matrix.os == 'windows-11-arm'
-        run: Add-AppxPackage -RegisterByFamilyName -MainPackage Microsoft.DesktopAppInstaller_8wekyb3d8bbwe
-      - name: Upgrade Git for Windows
-        run: winget upgrade git --silent --accept-source-agreements --accept-package-agreements
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false