Skip to content

Commit dcf9010

Browse files
committed
Actually build gix to check MSRV
This changes `cargo check` commands to `cargo build` in the `ci-check-msrv` recipe in the `justfile`, which the `check-msrv` CI jobs in `msrv.yml` use. The idea is to make sure at least `gix` (with the two combinations of features tested) actuall *builds* under the MSRV toolchain. As in f10f18d, this also updates the `Makefile` rule corresponding to that `justfile` recipe.
1 parent dc1d271 commit dcf9010

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ bench-gix-config:
126126

127127
check-msrv-on-ci: ## Check the minimal support rust version for currently installed Rust version
128128
rustc --version
129-
cargo check --locked --package gix
130-
cargo check --locked --package gix --no-default-features --features async-network-client,max-performance
129+
cargo build --locked --package gix
130+
cargo build --locked --package gix --no-default-features --features async-network-client,max-performance
131131

132132
##@ Maintenance
133133

justfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,8 @@ check-size:
246246
# Check the MSRV, *if* the toolchain is set and `Cargo.lock` is downgraded (used on CI)
247247
ci-check-msrv:
248248
rustc --version
249-
cargo check --locked -p gix
250-
cargo check --locked -p gix --no-default-features --features async-network-client,max-performance
249+
cargo build --locked -p gix
250+
cargo build --locked -p gix --no-default-features --features async-network-client,max-performance
251251

252252
# Enter a nix-shell able to build on macOS
253253
nix-shell-macos:

0 commit comments

Comments
 (0)