Skip to content

Commit eec407f

Browse files
committed
Move the vacuous case outside the "ordinary" group
The vacuous case is ordinary, both in the specific relevant sense of ordinary that there are no strange paths, and in the broader sense that it is expected for overly sanitized environments sometimes not to have any environment variables indicating where program files directories are. However, this is the simplest case, and calling it "ordinary" is confusing. This moves it to be first, renames it, and removes the now-obsolete comment.
1 parent edc0f3c commit eec407f

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

gix-path/src/env/git/tests.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ mod locations {
4949
}
5050
}
5151

52+
#[test]
53+
fn locations_under_program_files_no_vars() {
54+
assert_eq!(locations_from!(), Vec::<PathBuf>::new());
55+
}
56+
5257
#[test]
5358
fn locations_under_program_files_ordinary_values_current_var_only() {
5459
assert_eq!(
@@ -88,12 +93,6 @@ mod locations {
8893
);
8994
}
9095

91-
#[test]
92-
fn locations_under_program_files_ordinary_values_no_vars() {
93-
// Regarding this test name: the significance of "ordinary values" is "no strange values."
94-
assert_eq!(locations_from!(), Vec::<PathBuf>::new());
95-
}
96-
9796
#[test]
9897
fn locations_under_program_files_strange_values_all_vars_distinct() {
9998
assert_eq!(

0 commit comments

Comments
 (0)