From 8216dbbbb3bde7263d5616a05bdb786382035816 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Sat, 2 Aug 2025 17:05:31 -0400 Subject: [PATCH 1/2] Drop `set +x` in CI WASM steps It seems like it was intended to be `set -x`, but let's first see if it is doing something important by checking for any change when removing it. --- .github/workflows/ci.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ab698934c86..f74a462ffa1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -416,7 +416,6 @@ jobs: - name: 'WASI only: crates without feature toggle' if: endsWith(matrix.target, '-wasi') run: | - set +x for crate in gix-sec; do cargo build -p "$crate" --target "$TARGET" done @@ -447,19 +446,16 @@ jobs: gix-url gix-validate ) - set +x for crate in "${crates[@]}"; do cargo build -p "$crate" --target "$TARGET" done - name: features of gix-features run: | - set +x for feature in progress parallel io-pipe crc32 zlib cache-efficiency-debug; do cargo build -p gix-features --features "$feature" --target "$TARGET" done - name: crates with 'wasm' feature run: | - set +x for crate in gix-pack; do cargo build -p "$crate" --features wasm --target "$TARGET" done From b194fe15d9b272ba20f822b5c1d1d3826ded31de Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Sat, 2 Aug 2025 17:08:18 -0400 Subject: [PATCH 2/2] Add `set -x` where `set +x` had been erroneously used `set +x` is the default (in general, as well as in GitHub Actions unless the value of `shell` is modified with `-x` or `-o xtrace`). What is needed to distinguish which command from which iterations of the loops in the WASM jobs' steps' output is `set -x`. --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f74a462ffa1..73417387ded 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -416,6 +416,7 @@ jobs: - name: 'WASI only: crates without feature toggle' if: endsWith(matrix.target, '-wasi') run: | + set -x for crate in gix-sec; do cargo build -p "$crate" --target "$TARGET" done @@ -446,16 +447,19 @@ jobs: gix-url gix-validate ) + set -x for crate in "${crates[@]}"; do cargo build -p "$crate" --target "$TARGET" done - name: features of gix-features run: | + set -x for feature in progress parallel io-pipe crc32 zlib cache-efficiency-debug; do cargo build -p gix-features --features "$feature" --target "$TARGET" done - name: crates with 'wasm' feature run: | + set -x for crate in gix-pack; do cargo build -p "$crate" --features wasm --target "$TARGET" done