Fix Bug 🐛 invalid paraneter passed to response callback

Author: Albert Leitato

src/Drivers/EmalifySMS.php

@@ -35,11 +35,11 @@ public function __construct(Client $gateway)
     /**
      * Send sms message.
      *
-     * @param OutgoingMessage $message Elimuswift\SMS\OutgoingMessage
-     **@param \Closure|null $callback
+     * @param OutgoingMessage $message \Elimuswift\SMS\OutgoingMessage
+     *
      * @return Response Guzzle PSR response
      */
-    public function send(OutgoingMessage $message, \Closure $callback = null)
+    public function send(OutgoingMessage $message)
     {
         $options = [
             'from' => $message->getFrom(),

src/SMS.php

@@ -11,7 +11,7 @@ class SMS
     /**
      * The Driver Interface instance.
      *
-     * @var \Elimuswift\SMS\Drivers\DriverInterface
+     * @var Drivers\DriverInterface
      */
     protected $driver;
 
@@ -58,9 +58,10 @@ public function driver($driver)
      *
      * @param string $view the desired view
      * @param array $data the data that needs to be passed into the view
-     * @param \Closure $callback the methods that you wish to fun on the message
+     * @param Closure $callback the methods that you wish to fun on the message
+     * @param Closure|null $responseCallback
      *
-     * @return \Elimuswift\SMS\OutgoingMessage the outgoing message that was sent
+     * @return OutgoingMessage the outgoing message that was sent
      */
     public function send($view, $data, $callback, Closure $responseCallback = null)
     {
@@ -71,9 +72,9 @@ public function send($view, $data, $callback, Closure $responseCallback = null)
         $message->data($data);
 
         call_user_func($callback, $message);
-        $response = $this->driver->send($message, $responseCallback);
+        $response = $this->driver->send($message);
 
-        return $this->runCallbacks($response, $callback);
+        return $this->runCallbacks($response, $responseCallback);
     }
 
     /**
@@ -94,7 +95,7 @@ protected function runCallbacks($payload, $callback)
     /**
      * Creates a new Message instance.
      *
-     * @return \Elimuswift\SMS\OutgoingMessage
+     * @return OutgoingMessage
      */
     protected function createOutgoingMessage()
     {
@@ -168,7 +169,7 @@ public function getMessage($messageId)
     /**
      * Get the current diver .
      *
-     * @return \Elimuswift\SMS\Contracts\DriverInterface
+     * @return DriverInterface
      */
     public function getDriver()
     {