Finish Hotfix-0.8.2

Author: EliotVU

.editorconfig

@@ -9,6 +9,10 @@ indent_size = 4
 [*.{js,ts}]
 charset = utf-8
 
+[*.YAML-tmLanguage]
+indent_style = space
+indent_size = 2
+
 [{.travis.yml}]
 indent_style = space
 indent_size = 2

.vscode/extensions.json

@@ -3,7 +3,6 @@
         "redhat.vscode-yaml",
         "mike-lischke.vscode-antlr4",
         "eliotvu.uc",
-        "pedro-w.tmlanguage",
         "amodio.tsl-problem-matcher",
         "rbbit.typescript-hero",
         "nicoespeon.abracadabra",

.vscode/settings.json

@@ -35,4 +35,10 @@
     "unrealscript.checkTypes": true,
     "unrealscript.analyzeDocuments": "None",
     "unrealscript.generation": "3",
+    "files.associations": {
+        "*.YAML-tmLanguage": "yaml",
+    },
+    "yaml.schemas": {
+        "https://json.schemastore.org/tmlanguage.json": "*.YAML-tmLanguage"
+    }
 }

.vscode/tasks.json

@@ -6,7 +6,7 @@
             "type": "npm",
             "script": "build",
             "group": "build",
-            "problemMatcher": "$esbuild",
+            "problemMatcher": "$esbuild"
         },
         {
             "label": "npm: watch",
@@ -23,6 +23,40 @@
                 "reveal": "never",
                 "group": "watchers"
             }
+        },
+        {
+            "label": "npm: test /syntaxes/",
+            "type": "shell",
+            "command": "npm test",
+            "group": "test",
+            "presentation": {
+                "reveal": "always",
+                "panel": "new"
+            },
+            "problemMatcher": {
+                "owner": "vscode-tmgrammar-test",
+                "fileLocation": [
+                    "relative",
+                    "${workspaceRoot}/syntaxes"
+                ],
+                "pattern": [
+                    {
+                        "regexp": "^(ERROR)\\s([^:]+):(\\d+):(\\d+):(\\d+)\\s(.*)$",
+                        "severity": 1,
+                        "file": 2,
+                        "line": 3,
+                        "column": 4,
+                        "endColumn": 5,
+                        "message": 6
+                    }
+                ]
+            },
+            "runOptions": {
+                "runOn": "folderOpen",
+            },
+            "options": {
+                "cwd": "${workspaceRoot}/syntaxes"
+            }
         }
     ]
 }

CHANGELOG.md

@@ -1,5 +1,29 @@
 # UnrealScript Language Service
 
+## 0.8.2 (July 24, 2024)
+
+This hotfix mostly addresses problems with type checking (when 'check types' is enabled) and other minor issues:
+
+- Fixed [#190](https://github.com/EliotVU/UnrealScript-Language-Service/issues/190)
+- Fixed [#189](https://github.com/EliotVU/UnrealScript-Language-Service/issues/189)
+- Fixed [#188](https://github.com/EliotVU/UnrealScript-Language-Service/issues/188)
+- Fixed [#187](https://github.com/EliotVU/UnrealScript-Language-Service/issues/187)
+
+In order to fix all of the listed issues above, the type checking had to be expanded to validate and consider 'variables' modifiers, and as a result more incompatible types should be reported; but this may also cause more false-positives to be reported in cases where the data is incomplete (i.e. macros)
+
+- Fixed [#182; "Declaring static array size from variable fails in some cases"](https://github.com/EliotVU/UnrealScript-Language-Service/issues/182)
+
+## 0.8.1 (Juni 16, 2024)
+
+- (check types) Fixed false-positive `Type 'Object' and 'None' are incompatible with operator '!='`
+this occurred due a false 'same-cost' operator match for `Interface` types; furthermore supported type checking for `Interface` types.
+- (check types) Fixed false-positive `Type 'Struct' and 'Struct' are incompatible with operator '=='` this occurred when comparing structs that have no overloaded '=='
+- Fixed minor issues with completion suggestions, e.g. when writing `begin object name=<carret>` etc.
+- Fixed minor syntax highlighting issues, and added unit tests.
+- Fixed error popup 'names cannot be falsy' when writing multiple variables.
+- Fixed parenthesis `()` are no longer required for an `assert` statement.
+- Restricted grammar parsing of multiline assignments and parameter assignments to UE3 (set `generation` to 3 to enable)
+
 ## 0.8.0 (Juni 7, 2024)
 
 - Improvements made to type checking
@@ -19,7 +43,7 @@
   - Report if a deprecated `field` is referenced.
   - Report if an operator cannot be found.
   - (check types) Report if the operator is found, but no overload can be matched.
-  - Report if a class type cannot be cast or assigned to an unrelated class type, also report if the cast is redundant.
+  - (check types) Report if a class type cannot be cast or assigned to an unrelated class type, also report if the cast is redundant.
 - Quality of Life
   - General improvements made to parsing and indexing as to better align with the UnrealScript compiler's way of things.
   - If a `.uc` document has no `classes` in its path, then the containing directory's name will be used instead to represent the package name.

grammars/UCParser.g4

@@ -753,7 +753,7 @@ functionSpecifier
 functionName: identifier | operatorName;
 
 parameters: paramDecl (COMMA paramDecl)*;
-paramDecl: paramModifier* typeDecl variable (ASSIGNMENT expr=expression)?;
+paramDecl: paramModifier* typeDecl variable ({ this.generation === 3 }? ASSIGNMENT expr=expression)?;
 
 returnTypeModifier
 	: 'coerce' // UC3+
@@ -888,8 +888,11 @@ breakStatement: 'break' SEMICOLON;
 continueStatement: 'continue' SEMICOLON;
 stopStatement: 'stop' SEMICOLON;
 labeledStatement: identifier COLON;
+// expr is not optional, but we need to ensure we match this statement for every 'goto' identifier.
+// expr=identifier? if generation pre-UC3.
 gotoStatement: 'goto' expr=expression? SEMICOLON;
-assertStatement: 'assert' (OPEN_PARENS expr=expression? CLOSE_PARENS) SEMICOLON;
+// expr is not optional, but we need to ensure we match this statement for every 'assert' identifier.
+assertStatement: 'assert' expr=expression? SEMICOLON;
 
 // All valid operator names (for declarations)
 operatorName
@@ -959,8 +962,10 @@ primaryExpression
 	| primaryExpression (OPEN_PARENS arguments? CLOSE_PARENS) 								#callExpression
 	| primaryExpression (OPEN_BRACKET arg=expression? CLOSE_BRACKET) 						#elementAccessExpression
 
-	| 'new' 		(OPEN_PARENS arguments? CLOSE_PARENS)? expr=primaryExpression
-                    (OPEN_PARENS templateExpr=primaryExpression CLOSE_PARENS)?              #newExpression
+	| 'new' 		(OPEN_PARENS arguments CLOSE_PARENS)? expr=primaryExpression
+                    ({ this.generation === 3 }?
+                    OPEN_PARENS templateExpr=primaryExpression CLOSE_PARENS
+                    )?                                                                      #newExpression
 	| 'class' 		(LT identifier GT) (OPEN_PARENS expr=expression CLOSE_PARENS)			#metaClassExpression
 	| 'arraycount' 	(OPEN_PARENS expr=primaryExpression CLOSE_PARENS)						#arrayCountExpression
 	| 'super' 		(OPEN_PARENS identifier CLOSE_PARENS)?									#superExpression
@@ -1108,7 +1113,11 @@ defaultConstantArgument
 	;
 
 defaultAssignmentExpression
-	: defaultExpression ASSIGNMENT ((OPEN_BRACE defaultValue? CLOSE_BRACE) | defaultValue)
+	: defaultExpression ASSIGNMENT
+        (
+            ({ this.generation === 3 }? (OPEN_BRACE defaultValue? CLOSE_BRACE))
+            | defaultValue
+        )
 	;
 
 defaultMemberCallExpression