Merge pull request #110 from Ellerbach/mtirion/fix-issue-109

Fixed problem with non existing link

Author: mtirionMSFT

src/DocAssembler/DocAssembler.Test/IssueTests.cs

@@ -14,7 +14,6 @@ namespace DocAssembler.Test;
 
 public class IssueTests
 {
-    private Faker _faker = new();
     private MockFileService _fileService = new();
     private MockLogger _mockLogger = new();
     private ILogger _logger;
@@ -31,6 +30,45 @@ public IssueTests()
         _outputFolder = Path.Combine(_fileService.Root, "out");
     }
 
+    [Fact]
+    public async void Issue_90_invalidLinkCausesStartIndexError()
+    {
+        _fileService.Files.Clear();
+
+        string expected =
+@"#Documentation Readme
+
+LINK [title](../../../non-existing-file.md)".NormalizeContent();
+
+        var folder = _fileService.AddFolder($"docs");
+        _fileService.AddFile(folder, "README.md", string.Empty
+            .AddRaw(expected));
+
+        // arrange
+        AssembleConfiguration config = new AssembleConfiguration
+        {
+            DestinationFolder = "out",
+            ExternalFilePrefix = "https://some-url.com",
+            Content =
+            [
+                new Content
+                {
+                    SourceFolder = "docs",
+                    DestinationFolder = "general",
+                    Files = { "**" },
+                }
+            ]
+        };
+
+        InventoryAction action = new(_workingFolder, config, _fileService, _logger);
+
+        // act
+        var ret = await action.RunAsync();
+
+        // assert
+        ret.Should().Be(ReturnCode.Error);
+    }
+
     [Fact]
     public async void Issue_89_refHeaderInSameFile()
     {

src/DocAssembler/DocAssembler/Actions/InventoryAction.cs

@@ -128,10 +128,11 @@ private ReturnCode UpdateLinks()
                         else
                         {
                             var prefix = file.ContentSet!.ExternalFilePrefix ?? _config.ExternalFilePrefix;
-                            if (string.IsNullOrEmpty(prefix))
+                            if (string.IsNullOrEmpty(prefix) ||
+                                !link.UrlFullPath.StartsWith(_workingFolder.NormalizePath(), StringComparison.OrdinalIgnoreCase))
                             {
                                 // ERROR: no solution to fix this reference
-                                _logger.LogCritical($"Error in a file reference. Link '{link.OriginalUrl}' in '{file.SourcePath}' cannot be resolved and no external file prefix was given.");
+                                _logger.LogCritical($"Error in a file reference in '{file.SourcePath}'. Link '{link.OriginalUrl}' on {link.Line},{link.Column} cannot be resolved or no external file prefix was given.");
                                 ret = ReturnCode.Error;
                             }
                             else