Merge pull request #49 from vcatechnology/non-enumerable-length

Prevent internal __length property from being enumerable

Author: ElliotNB

observable-slim.js

@@ -61,8 +61,13 @@ var ObservableSlim = (function() {
 		// in order to accurately report the "previous value" of the "length" property on an Array
 		// we must use a helper property because intercepting a length change is not always possible as of 8/13/2018 in 
 		// Chrome -- the new `length` value is already set by the time the `set` handler is invoked
-		if (target instanceof Array) target.__length = target.length;
-		
+		if (target instanceof Array) {
+			if (!target.hasOwnProperty("__length"))
+				Object.defineProperty(target, "__length", { enumerable: false, value: target.length, writable: true });
+			else
+				target.__length = target.length;
+			}
+
 		var changes = [];
 
 		/*	Function: _getPath

test/test.js

@@ -774,7 +774,23 @@ function suite(proxy) {
 			expect(p.test.deeper.__getPath).to.equal("test.deeper");
 			expect(p.arr[0].test.__getPath).to.equal("arr.0.test");
 		}
-		
+
+	});
+
+	it('42. Array does not enumerate __length.', () => {
+		var largeArray = [];
+
+		for (var i = 0; i < 5; i++) {
+			largeArray.push({
+				"hello":"world"
+				,"foo":"bar"
+			});
+		}
+
+		var proxyArr = ObservableSlim.create(largeArray, false, function(changes) {});
+
+		var keys = Array.from(proxyArr.keys());
+		expect(keys.every(item => !Number.isNaN(item))).to.be.true;
 	});
 
 };