Remove compatibility mode (#23)

* Remove Eluna compatibility mode
* Update Eluna submodule

Author: Foereaper

src/server/game/Entities/Object/Object.cpp

@@ -1825,16 +1825,13 @@ void WorldObject::SetMap(Map* map)
     m_mapId = map->GetId();
     m_InstanceId = map->GetInstanceId();
 #ifdef ELUNA
-    // in multistate mode, always reset Map events, then recreate the Map events procesor
-    if (!sElunaConfig->IsElunaCompatibilityMode())
-    {
-        auto& events = GetElunaEvents(m_mapId);
-        if (events)
-            events.reset();
+    // always reset Map events, then recreate the Map events procesor if Eluna is enabled for the map
+    auto& events = GetElunaEvents(m_mapId);
+    if (events)
+        events.reset();
 
-        if (Eluna* e = map->GetEluna())
-            events = std::make_unique<ElunaEventProcessor>(e, this);
-    }
+    if (Eluna* e = map->GetEluna())
+        events = std::make_unique<ElunaEventProcessor>(e, this);
 
     // create the World events processor
     if (Eluna* e = sWorld->GetEluna())

src/server/game/LuaEngine

@@ -289,7 +289,7 @@ i_scriptLock(false), _respawnTimes(std::make_unique<RespawnListContainer>()), _r
     // lua state begins uninitialized
     eluna = nullptr;
 
-    if (sElunaConfig->IsElunaEnabled() && !sElunaConfig->IsElunaCompatibilityMode() && sElunaConfig->ShouldMapLoadEluna(id))
+    if (sElunaConfig->IsElunaEnabled() && sElunaConfig->ShouldMapLoadEluna(id))
         if (!IsParentMap() || (IsParentMap() && !Instanceable()))
             eluna = std::make_unique<Eluna>(this);
 #endif
@@ -4891,14 +4891,4 @@ std::string InstanceMap::GetDebugInfo() const
     return sstr.str();
 }
 
-#ifdef ELUNA
-Eluna *Map::GetEluna() const
-{
-    if(sElunaConfig->IsElunaCompatibilityMode())
-        return sWorld->GetEluna();
-
-    return eluna.get();
-}
-#endif
-
 template class TC_GAME_API TypeUnorderedMapContainer<AllMapStoredObjectTypes, ObjectGuid>;

src/server/game/Maps/Map.cpp

@@ -788,7 +788,7 @@ class TC_GAME_API Map : public GridRefManager<NGridType>
         void AddFarSpellCallback(FarSpellCallback&& callback);
         bool IsParentMap() const { return GetParent() == this; }
 #ifdef ELUNA
-        Eluna* GetEluna() const;
+        Eluna* GetEluna() const { return eluna.get(); }
 
         LuaVal lua_data = LuaVal({});
 #endif

src/server/game/Maps/Map.h

@@ -38,7 +38,6 @@
 #include <numeric>
 #ifdef ELUNA
 #include "LuaEngine.h"
-#include "ElunaConfig.h"
 #endif
 
 MapManager::MapManager()
@@ -55,15 +54,6 @@ void MapManager::Initialize()
     Map::InitStateMachine();
 
     int num_threads(sWorld->getIntConfig(CONFIG_NUMTHREADS));
-#if ELUNA
-    if (sElunaConfig->IsElunaEnabled() && sElunaConfig->IsElunaCompatibilityMode() && num_threads > 1)
-    {
-        // Force 1 thread for Eluna if compatibility mode is enabled. Compatibility mode is single state and does not allow more update threads.
-        TC_LOG_ERROR("maps", "Map update threads set to {}, when Eluna in compatibility mode only allows 1, changing to 1", num_threads);
-        num_threads = 1;
-    }
-#endif
-
     // Start mtmaps if needed.
     if (num_threads > 0)
         m_updater.activate(num_threads);

src/server/game/Maps/MapManager.cpp

@@ -1560,9 +1560,7 @@ void ScriptMgr::OnMapUpdate(Map* map, uint32 diff)
 #ifdef ELUNA
     if (Eluna* e = map->GetEluna())
     {
-        if(!sElunaConfig->IsElunaCompatibilityMode())
-            e->UpdateEluna(diff);
-
+        e->UpdateEluna(diff);
         e->OnUpdate(map, diff);
     }
 #endif

src/server/game/Scripting/ScriptMgr.cpp

@@ -2131,7 +2131,7 @@ void World::SetInitialWorldSettings()
     if (sElunaConfig->IsElunaEnabled())
     {
         TC_LOG_INFO("server.loading", "Starting Eluna world state...");
-        eluna = std::make_unique<Eluna>(nullptr, sElunaConfig->IsElunaCompatibilityMode());
+        eluna = std::make_unique<Eluna>(nullptr);
     }
 #endif
 

src/server/game/World/World.cpp

@@ -3889,12 +3889,6 @@ AuctionHouseBot.Buyer.Recheck.Interval = 20
 #       Default:     true  - (enabled)
 #                    false - (disabled)
 #
-#   Eluna.CompatibilityMode
-#       Description: Toggles Eluna between compatibility mode (single-threaded) or multistate mode. 
-#                    Compatibility mode limits the core to a single map update thread.
-#       Default:     true  - (enabled)
-#                    false - (disabled)
-#
 #   Eluna.ScriptReloader
 #       Description: Enable or disable the automated script reloader.
 #                    This will automatically reload Eluna when it detects changes to scripts.
@@ -3934,7 +3928,6 @@ AuctionHouseBot.Buyer.Recheck.Interval = 20
 #
 
 Eluna.Enabled = true
-Eluna.CompatibilityMode = false
 Eluna.ScriptReloader = false
 Eluna.OnlyOnMaps = ""
 Eluna.TraceBack = false