chore: temp update redis calls

Author: odouglas-es

api/frontend.proto

@@ -152,6 +152,15 @@ message GetIndexedTicketCountResponse{
   int32 count =1;
 }
 
+message GetExpiredTicketIdsRequest {
+  int32 limit = 1;
+}
+
+message GetExpiredTicketIdsResponse {
+  repeated string ticket_ids = 1;
+}
+
+
 // The FrontendService implements APIs to manage and query status of a Tickets.
 service FrontendService {
   // CreateTicket assigns an unique TicketId to the input Ticket and record it in state storage.
@@ -271,4 +280,12 @@ service FrontendService {
       body: "*"
     };
   }
+
+  // GetExpiredTicketIds get the expired tickets limited by the specified number
+  rpc GetExpiredTicketIds(GetExpiredTicketIdsRequest) returns (GetExpiredTicketIdsResponse) {
+    option (google.api.http) = {
+      post: "/v1/frontendservice/tickets/expired"
+      body: "*"
+    };
+  }
 }

api/frontend.swagger.json

@@ -425,14 +425,14 @@
       }
     },
     "/v1/frontendservice/tickets/expired": {
-      "get": {
-        "summary": "GetExpiredTickets returns the ticket Ids corresponding to tickets outside the valid window",
-        "operationId": "FrontendService_GetExpiredTickets",
+      "post": {
+        "summary": "GetExpiredTicketIds get the expired tickets limited by the specified number",
+        "operationId": "FrontendService_GetExpiredTicketIds",
         "responses": {
           "200": {
             "description": "A successful response.",
             "schema": {
-              "$ref": "#/definitions/openmatchGetExpiredTicketsResponse"
+              "$ref": "#/definitions/openmatchGetExpiredTicketIdsResponse"
             }
           },
           "404": {
@@ -451,12 +451,12 @@
         },
         "parameters": [
           {
-            "name": "limit",
-            "description": "The limit on how many ticket Ids to return",
-            "in": "query",
-            "required": false,
-            "type": "integer",
-            "format": "int32"
+            "name": "body",
+            "in": "body",
+            "required": true,
+            "schema": {
+              "$ref": "#/definitions/openmatchGetExpiredTicketIdsRequest"
+            }
           }
         ],
         "tags": [
@@ -711,15 +711,23 @@
         }
       }
     },
-    "openmatchGetExpiredTicketsResponse": {
+    "openmatchGetExpiredTicketIdsRequest": {
+      "type": "object",
+      "properties": {
+        "limit": {
+          "type": "integer",
+          "format": "int32"
+        }
+      }
+    },
+    "openmatchGetExpiredTicketIdsResponse": {
       "type": "object",
       "properties": {
         "ticket_ids": {
           "type": "array",
           "items": {
             "type": "string"
-          },
-          "description": "Expired TicketIds of generated Tickets to be deleted."
+          }
         }
       }
     },

internal/app/frontend/frontend_service.go

@@ -496,3 +496,17 @@ func (s *frontendService) GetTickets(ctx context.Context, req *pb.GetTicketsRequ
 
 	return resp, nil
 }
+
+// GetExpiredTicketIds get the expired tickets limited by the specified number
+func (s *frontendService) GetExpiredTicketIds(ctx context.Context, req *pb.GetExpiredTicketIdsRequest) (*pb.GetExpiredTicketIdsResponse, error) {
+	ticketIds, err := s.store.GetExpiredTicketIDs(ctx, int(req.GetLimit()))
+	if err != nil {
+		return nil, err
+	}
+
+	response := &pb.GetExpiredTicketIdsResponse{
+		TicketIds: ticketIds,
+	}
+
+	return response, nil
+}

internal/statestore/ticket.go

@@ -203,12 +203,6 @@ func (rb *redisBackend) IndexTicket(ctx context.Context, ticket *pb.Ticket) erro
 	}
 	defer handleConnectionClose(&redisConn)
 
-	err = redisConn.Send("SADD", allTickets, ticket.Id)
-	if err != nil {
-		err = errors.Wrapf(err, "failed to add ticket to all tickets, id: %s", ticket.Id)
-		return status.Errorf(codes.Internal, "%v", err)
-	}
-
 	ticketTTL := getTicketReleaseTimeout(rb.cfg)
 	expiry := time.Now().Add(ticketTTL).UnixNano()
 	err = redisConn.Send("ZADD", allTicketsWithTTL, expiry, ticket.Id)
@@ -228,12 +222,6 @@ func (rb *redisBackend) DeindexTicket(ctx context.Context, id string) error {
 	}
 	defer handleConnectionClose(&redisConn)
 
-	err = redisConn.Send("SREM", allTickets, id)
-	if err != nil {
-		err = errors.Wrapf(err, "failed to remove ticket from all tickets, id: %s", id)
-		return status.Errorf(codes.Internal, "%v", err)
-	}
-
 	err = redisConn.Send("ZREM", allTicketsWithTTL, id)
 	if err != nil {
 		err = errors.Wrapf(err, "failed to remove ticket from all tickets, id: %s", id)
@@ -252,18 +240,11 @@ func (rb *redisBackend) DeindexTickets(ctx context.Context, ids []string) error
 	defer handleConnectionClose(&redisConn)
 
 	args := make([]any, len(ids)+1)
-	args[0] = allTickets
+	args[0] = allTicketsWithTTL
 	for i, id := range ids {
 		args[i+1] = id
 	}
 
-	err = redisConn.Send("SREM", args...)
-	if err != nil {
-		err = errors.Wrapf(err, "failed to remove ticket from all tickets, id: %v", ids)
-		return status.Errorf(codes.Internal, "%v", err)
-	}
-
-	args[0] = allTicketsWithTTL
 	err = redisConn.Send("ZREM", args...)
 	if err != nil {
 		err = errors.Wrapf(err, "failed to remove ticket from all tickets, id: %v", ids)