Fix string testing anti-pattern.

webbju · webbju · commit a185be32a871 · 2025-12-08T10:03:30.000+01:00
diff --git a/ServerCodeExciser/ServerCodeExcisionProcessor.cs b/ServerCodeExciser/ServerCodeExcisionProcessor.cs
@@ -37,7 +37,7 @@ public ServerCodeExcisionProcessor(ServerCodeExcisionParameters parameters)
             _parameters = parameters;
 
             _functionExciseRegexes = new List<Regex>();
-            if (_parameters.ExciseAllFunctionsRegexString != "")
+            if (!string.IsNullOrEmpty(_parameters.ExciseAllFunctionsRegexString))
             {
                 var allFunctionExciseRegexStrings = _parameters.ExciseAllFunctionsRegexString.Split("|||");
                 foreach (var regexString in allFunctionExciseRegexStrings)
@@ -48,7 +48,7 @@ public ServerCodeExcisionProcessor(ServerCodeExcisionParameters parameters)
             }
 
             _fullyExciseRegexes = new List<Regex>();
-            if (_parameters.FullExcisionRegexString != "")
+            if (!string.IsNullOrEmpty(_parameters.FullExcisionRegexString))
             {
                 var fullyExciseRegexStrings = _parameters.FullExcisionRegexString.Split("|||");
                 foreach (var regexString in fullyExciseRegexStrings)

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public ServerCodeExcisionProcessor(ServerCodeExcisionParameters parameters)`
`37`	`37`	`_parameters = parameters;`
`38`	`38`
`39`	`39`	`_functionExciseRegexes = new List<Regex>();`
`40`		`- if (_parameters.ExciseAllFunctionsRegexString != "")`
	`40`	`+ if (!string.IsNullOrEmpty(_parameters.ExciseAllFunctionsRegexString))`
`41`	`41`	`{`
`42`	`42`	`var allFunctionExciseRegexStrings = _parameters.ExciseAllFunctionsRegexString.Split("\|\|\|");`
`43`	`43`	`foreach (var regexString in allFunctionExciseRegexStrings)`
`@@ -48,7 +48,7 @@ public ServerCodeExcisionProcessor(ServerCodeExcisionParameters parameters)`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`_fullyExciseRegexes = new List<Regex>();`
`51`		`- if (_parameters.FullExcisionRegexString != "")`
	`51`	`+ if (!string.IsNullOrEmpty(_parameters.FullExcisionRegexString))`
`52`	`52`	`{`
`53`	`53`	`var fullyExciseRegexStrings = _parameters.FullExcisionRegexString.Split("\|\|\|");`
`54`	`54`	`foreach (var regexString in fullyExciseRegexStrings)`