Better error handling for actions

Author: EmberLightVFX

.github/workflows/reprocess_sensor_pr.yml

@@ -24,48 +24,66 @@ jobs:
         uses: actions/github-script@v7
         with:
           script: |
-            const prNumber = ${{ inputs.pr_number }};
-            const pr = await github.rest.pulls.get({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: prNumber
-            });
-
-            // Get PR body and branch name
-            const prBody = pr.data.body;
-            const branchName = pr.data.head.ref;
-
-            // Output the PR body and branch name
-            core.setOutput('pr_body', prBody);
-            core.setOutput('branch_name', branchName);
-
-            return {prBody, branchName};
+            try {
+              const prNumber = ${{ inputs.pr_number }};
+              const pr = await github.rest.pulls.get({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                pull_number: prNumber
+              });
+
+              // Get branch name
+              const branchName = pr.data.head.ref;
+
+              // Output the branch name only, not the body
+              core.setOutput('branch_name', branchName);
+              
+              return { branchName };
+            } catch (error) {
+              console.error('Error getting PR data:', error);
+              core.setFailed(`Failed to get PR data: ${error.message}`);
+            }
 
       - name: Extract details from PR body
         id: info
         uses: actions/github-script@v7
         with:
           script: |
-            const prBody = '${{ steps.pr_data.outputs.pr_body }}';
-
-            // More robust pattern matching with regex
-            const vendorMatch = prBody.match(/### Vendor\s*\n\s*\n\s*(.*?)(\n\s*\n|\n\s*###|$)/s);
-            const cameraMatch = prBody.match(/### Camera\s*\n\s*\n\s*(.*?)(\n\s*\n|\n\s*###|$)/s);
-
-            let vendor = vendorMatch ? vendorMatch[1].trim() : '';
-            const camera = cameraMatch ? cameraMatch[1].trim() : '';
-
-            if (vendor === 'Other') {
-              const otherVendorMatch = prBody.match(/### Other Vendor\s*\n\s*\n\s*(.*?)(\n\s*\n|\n\s*###|$)/s);
-              if (otherVendorMatch) vendor = otherVendorMatch[1].trim();
+            const prBody = context.payload.inputs.pr_body || '';
+            try {
+              // Get PR data first
+              const prNumber = ${{ inputs.pr_number }};
+              const pr = await github.rest.pulls.get({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                pull_number: prNumber
+              });
+              
+              // Get PR body from the actual PR data
+              const prBodyText = pr.data.body || '';
+              
+              // More robust pattern matching with regex
+              const vendorMatch = prBodyText.match(/### Vendor\s*\n\s*\n\s*(.*?)(\n\s*\n|\n\s*###|$)/s);
+              const cameraMatch = prBodyText.match(/### Camera\s*\n\s*\n\s*(.*?)(\n\s*\n|\n\s*###|$)/s);
+              
+              let vendor = vendorMatch ? vendorMatch[1].trim() : '';
+              const camera = cameraMatch ? cameraMatch[1].trim() : '';
+              
+              if (vendor === 'Other') {
+                const otherVendorMatch = prBodyText.match(/### Other Vendor\s*\n\s*\n\s*(.*?)(\n\s*\n|\n\s*###|$)/s);
+                if (otherVendorMatch) vendor = otherVendorMatch[1].trim();
+              }
+              
+              core.exportVariable('vendor', vendor);
+              core.exportVariable('camera', camera);
+              
+              console.log(`Extracted Vendor: ${vendor}`);
+              console.log(`Extracted Camera: ${camera}`);
+            } catch (error) {
+              console.error('Error extracting PR details:', error);
+              core.setFailed(`Failed to extract PR details: ${error.message}`);
             }
 
-            core.exportVariable('vendor', vendor);
-            core.exportVariable('camera', camera);
-
-            console.log(`Extracted Vendor: ${vendor}`);
-            console.log(`Extracted Camera: ${camera}`);
-
       - name: Debug extracted data
         run: |
           echo "Vendor: ${{ env.vendor }}"
@@ -79,9 +97,31 @@ jobs:
 
       - name: Process and update JSON with Python
         id: python
-        run: |
-          pip install -r ./scripts/requirements.txt
-          python3 ./scripts/update_sensors_and_generate_json.py "${{ steps.pr_data.outputs.pr_body }}" 2> python_error.log || { cat python_error.log; echo "::set-output name=error::$(cat python_error.log)"; exit 1; }
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const { execSync } = require('child_process');
+            try {
+              // Get PR data first to get body
+              const prNumber = ${{ inputs.pr_number }};
+              const pr = await github.rest.pulls.get({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                pull_number: prNumber
+              });
+              
+              // Write PR body to a file to avoid command line escaping issues
+              const fs = require('fs');
+              fs.writeFileSync('pr_body.txt', pr.data.body || '');
+              
+              const result = execSync('pip install -r ./scripts/requirements.txt && python3 ./scripts/update_sensors_and_generate_json.py "$(cat pr_body.txt)" 2> python_error.log || { cat python_error.log; exit 1; }', { encoding: 'utf8' });
+              console.log(result);
+            } catch (error) {
+              console.error('Error running Python script:', error);
+              const errorLog = require('fs').readFileSync('python_error.log', 'utf8');
+              core.setOutput('error', errorLog);
+              core.setFailed(`Failed to run Python script: ${error.message}`);
+            }
 
       - name: Generate csv
         id: csv