Skip to content

Commit 23602fb

Browse files
authored
Remove Reaper (#682)
1 parent 929f448 commit 23602fb

File tree

5 files changed

+4
-40
lines changed

5 files changed

+4
-40
lines changed

android/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## Unreleased
99

10+
- Remove Reaper [#682](https://github.com/EmergeTools/hackernews/pull/682).
1011
- Bump SentrySDK to 8.17.0
1112
- Fix crash when title is null [#514](https://github.com/EmergeTools/hackernews/pull/514)
1213
- Set Compile SDK to 36

android/app/build.gradle.kts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ android {
4747
release {
4848
isDebuggable = false
4949
isMinifyEnabled = true
50-
isShrinkResources = true
50+
isShrinkResources = false
5151
proguardFiles(
5252
getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro"
5353
)
@@ -97,11 +97,6 @@ emerge {
9797
tag.set("snapshot")
9898
}
9999

100-
reaper {
101-
enabledVariants.set(listOf("playStoreRelease"))
102-
publishableApiKey.set(System.getenv("REAPER_API_KEY"))
103-
}
104-
105100
vcs {
106101
gitHub {
107102
// System.getenv override is for integration tests from the emerge-android repository
@@ -122,8 +117,8 @@ sentry {
122117
}
123118

124119
distribution {
125-
enabled = providers.environmentVariable("GITHUB_ACTIONS").isPresent
126-
updateSdkVariants.add("beta")
120+
//enabled = providers.environmentVariable("GITHUB_ACTIONS").isPresent
121+
//updateSdkVariants.add("beta")
127122
}
128123

129124
vcsInfo {
@@ -183,5 +178,4 @@ dependencies {
183178
debugImplementation(libs.androidx.ui.tooling)
184179
debugImplementation(libs.androidx.ui.test.manifest)
185180

186-
implementation(libs.emerge.reaper)
187181
}

android/app/src/main/AndroidManifest.xml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -18,30 +18,6 @@
1818

1919
<profileable android:shell="true" />
2020

21-
<!-- This demonstrates manual initialization of Reaper.
22-
See https://docs.emergetools.com/docs/reaper-setup-android#disable-automatic-initialization -->
23-
<provider
24-
android:name="androidx.startup.InitializationProvider"
25-
android:authorities="${applicationId}.androidx-startup"
26-
android:exported="false"
27-
tools:node="merge">
28-
<meta-data android:name="com.emergetools.reaper.ReaperInitializer"
29-
tools:node="remove" />
30-
</provider>
31-
32-
<!-- The Reaper library sends data to two endpoints:
33-
- $baseUrl/report
34-
- $baseUrl/reaper/error
35-
So if baseUrl is set to https://example.com/foo as
36-
below Reaper reports will be sent to:
37-
- https://example.com/foo/report
38-
and errors will be sent to:
39-
- https://example.com/foo/reaper/error
40-
-->
41-
<meta-data
42-
android:name="com.emergetools.OVERRIDE_BASE_URL"
43-
android:value="https://example.com/foo" />
44-
4521
<meta-data
4622
android:name="io.sentry.dsn"
4723
android:value="https://[email protected]/4510398352719872" />

android/app/src/main/java/com/emergetools/hackernews/HackerNewsApplication.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import com.emergetools.hackernews.data.local.UserStorage
1313
import com.emergetools.hackernews.data.remote.HackerNewsBaseClient
1414
import com.emergetools.hackernews.data.remote.HackerNewsSearchClient
1515
import com.emergetools.hackernews.data.remote.HackerNewsWebClient
16-
import com.emergetools.reaper.Reaper
1716
import io.sentry.Sentry
1817
import kotlinx.serialization.json.Json
1918
import okhttp3.OkHttpClient
@@ -35,10 +34,6 @@ class HackerNewsApplication : Application() {
3534

3635
Sentry.logger().info("HackerNewsApplication#onCreate")
3736

38-
// This demonstrates manual initialization of Reaper.
39-
// See https://docs.emergetools.com/docs/reaper-setup-android#manual-initialization
40-
Reaper.init(applicationContext)
41-
4237
val db = Room.databaseBuilder(
4338
applicationContext,
4439
HackerNewsDatabase::class.java,

android/gradle/libs.versions.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ navigation = "2.9.6"
1818
browser = "1.9.0"
1919
emergePlugin = "4.4.0"
2020
emergeSnapshots = "1.5.0"
21-
emergeReaper = "1.0.1"
2221
sentry = "6.0.0-beta.2"
2322
shapes = "1.1.0"
2423
datastore = "1.2.0"
@@ -64,7 +63,6 @@ jsoup = { group = "org.jsoup", name = "jsoup", version.ref = "jsoup" }
6463

6564
emerge-snapshots = { group = "com.emergetools.snapshots", name = "snapshots", version.ref = "emergeSnapshots" }
6665
emerge-snapshots-runtime = { group = "com.emergetools.snapshots", name = "snapshots-runtime", version.ref = "emergeSnapshots" }
67-
emerge-reaper = { group = "com.emergetools.reaper", name = "reaper", version.ref = "emergeReaper" }
6866

6967
junit = { group = "junit", name = "junit", version.ref = "junit" }
7068
robolectric = { group = "org.robolectric", name = "robolectric", version.ref = "robolectric" }

0 commit comments

Comments
 (0)