Skip to content

Commit 4e20774

Browse files
authored
Merge pull request #31 from yeweiran/BlackTower/FixSignatureHelpBug
Fix SignatureHelp block other vscode extension issue
2 parents 16e857b + 50ce63e commit 4e20774

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

EmmyLua-LS/src/main/kotlin/com/tang/vscode/LuaTextDocumentService.kt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -550,8 +550,9 @@ class LuaTextDocumentService(private val workspace: LuaWorkspaceService) : TextD
550550

551551
}
552552

553-
override fun signatureHelp(position: TextDocumentPositionParams): CompletableFuture<SignatureHelp> {
553+
override fun signatureHelp(position: TextDocumentPositionParams): CompletableFuture<SignatureHelp?> {
554554
return computeAsync {
555+
var signatureHelp: SignatureHelp? = null
555556
val list = mutableListOf<SignatureInformation>()
556557
var activeParameter = 0
557558
var activeSig = 0
@@ -595,7 +596,10 @@ class LuaTextDocumentService(private val workspace: LuaWorkspaceService) : TextD
595596
}
596597
}
597598
}
598-
SignatureHelp(list, activeSig, activeParameter)
599+
if (list.size > 0) {
600+
signatureHelp = SignatureHelp(list, activeSig, activeParameter)
601+
}
602+
signatureHelp
599603
}
600604
}
601605

0 commit comments

Comments
 (0)