Skip to content

Commit 2d1423e

Browse files
committed
clean code
1 parent 9dca0ec commit 2d1423e

File tree

6 files changed

+23
-31
lines changed

6 files changed

+23
-31
lines changed

src/main/java/com/tang/intellij/lua/editor/completion/ClassMemberCompletionProvider.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import com.intellij.codeInsight.completion.*
2020
import com.intellij.codeInsight.lookup.LookupElement
2121
import com.intellij.openapi.progress.ProgressManager
2222
import com.intellij.openapi.project.Project
23-
import com.intellij.util.ProcessingContext
2423
import com.intellij.util.Processor
2524
import com.tang.intellij.lua.lang.LuaIcons
2625
import com.tang.intellij.lua.psi.*
@@ -38,15 +37,16 @@ enum class MemberCompletionMode {
3837
3938
* Created by tangzx on 2016/12/25.
4039
*/
41-
open class ClassMemberCompletionProvider : CompletionProvider<CompletionParameters>() {
40+
open class ClassMemberCompletionProvider : LuaCompletionProvider() {
4241
protected abstract class HandlerProcessor {
4342
open fun processLookupString(lookupString: String, member: LuaClassMember, memberTy: ITy?): String = lookupString
4443
abstract fun process(element: LuaLookupElement, member: LuaClassMember, memberTy: ITy?): LookupElement
4544
}
4645

47-
override fun addCompletions(completionParameters: CompletionParameters,
48-
processingContext: ProcessingContext,
49-
completionResultSet: CompletionResultSet) {
46+
override fun addCompletions(session: CompletionSession) {
47+
val completionParameters = session.parameters
48+
val completionResultSet = session.resultSet
49+
5050
val psi = completionParameters.position
5151
val indexExpr = psi.parent
5252

src/main/java/com/tang/intellij/lua/editor/completion/LocalAndGlobalCompletionProvider.kt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,8 @@
1616

1717
package com.tang.intellij.lua.editor.completion
1818

19-
import com.intellij.codeInsight.completion.CompletionParameters
20-
import com.intellij.codeInsight.completion.CompletionResultSet
2119
import com.intellij.codeInsight.lookup.LookupElementBuilder
2220
import com.intellij.psi.tree.TokenSet
23-
import com.intellij.util.ProcessingContext
2421
import com.intellij.util.Processor
2522
import com.tang.intellij.lua.Constants
2623
import com.tang.intellij.lua.highlighting.LuaSyntaxHighlighter
@@ -33,7 +30,7 @@ import com.tang.intellij.lua.ty.*
3330
* suggest local/global vars and functions
3431
* Created by TangZX on 2017/4/11.
3532
*/
36-
class LocalAndGlobalCompletionProvider internal constructor(private val mask: Int) : ClassMemberCompletionProvider() {
33+
class LocalAndGlobalCompletionProvider(private val mask: Int) : ClassMemberCompletionProvider() {
3734

3835
private fun has(flag: Int): Boolean {
3936
return mask and flag == flag
@@ -78,8 +75,9 @@ class LocalAndGlobalCompletionProvider internal constructor(private val mask: In
7875
}
7976
}
8077

81-
override fun addCompletions(completionParameters: CompletionParameters, processingContext: ProcessingContext, completionResultSet: CompletionResultSet) {
82-
val session = completionParameters.editor.getUserData(CompletionSession.KEY)!!
78+
override fun addCompletions(session: CompletionSession) {
79+
val completionParameters = session.parameters
80+
val completionResultSet = session.resultSet
8381
val cur = completionParameters.position
8482
val nameExpr = cur.parent
8583

src/main/java/com/tang/intellij/lua/editor/completion/OverrideCompletionProvider.kt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,29 +17,28 @@
1717
package com.tang.intellij.lua.editor.completion
1818

1919
import com.intellij.codeInsight.completion.CompletionParameters
20-
import com.intellij.codeInsight.completion.CompletionProvider
2120
import com.intellij.codeInsight.completion.CompletionResultSet
2221
import com.intellij.codeInsight.lookup.LookupElementBuilder
2322
import com.intellij.codeInsight.template.Template
2423
import com.intellij.codeInsight.template.TemplateManager
2524
import com.intellij.psi.util.PsiTreeUtil
26-
import com.intellij.util.ProcessingContext
2725
import com.intellij.util.Processor
2826
import com.tang.intellij.lua.lang.LuaIcons
2927
import com.tang.intellij.lua.psi.*
3028
import com.tang.intellij.lua.search.SearchContext
3129
import com.tang.intellij.lua.stubs.index.LuaClassMemberIndex
3230
import com.tang.intellij.lua.ty.ITy
33-
import com.tang.intellij.lua.ty.ITyClass
3431
import com.tang.intellij.lua.ty.TyClass
3532
import com.tang.intellij.lua.ty.TyLazyClass
3633

3734
/**
3835
* override supper
3936
* Created by tangzx on 2016/12/25.
4037
*/
41-
class OverrideCompletionProvider : CompletionProvider<CompletionParameters>() {
42-
override fun addCompletions(completionParameters: CompletionParameters, processingContext: ProcessingContext, completionResultSet: CompletionResultSet) {
38+
class OverrideCompletionProvider : LuaCompletionProvider() {
39+
override fun addCompletions(session: CompletionSession) {
40+
val completionParameters = session.parameters
41+
val completionResultSet = session.resultSet
4342
val id = completionParameters.position
4443
val methodDef = PsiTreeUtil.getParentOfType(id, LuaClassMethodDef::class.java)
4544
if (methodDef != null) {

src/main/java/com/tang/intellij/lua/editor/completion/RequirePathCompletionProvider.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import com.intellij.openapi.roots.ModuleRootManager
2525
import com.intellij.openapi.roots.impl.ProjectFileIndexFacade
2626
import com.intellij.openapi.util.io.FileUtil
2727
import com.intellij.openapi.vfs.VirtualFile
28-
import com.intellij.util.ProcessingContext
2928
import com.tang.intellij.lua.lang.LuaFileType
3029
import com.tang.intellij.lua.lang.LuaIcons
3130
import com.tang.intellij.lua.lang.type.LuaString
@@ -34,9 +33,10 @@ import com.tang.intellij.lua.lang.type.LuaString
3433
*
3534
* Created by tangzx on 2016/12/25.
3635
*/
37-
class RequirePathCompletionProvider : CompletionProvider<CompletionParameters>() {
38-
39-
override fun addCompletions(completionParameters: CompletionParameters, processingContext: ProcessingContext, completionResultSet: CompletionResultSet) {
36+
class RequirePathCompletionProvider : LuaCompletionProvider() {
37+
override fun addCompletions(session: CompletionSession) {
38+
val completionParameters = session.parameters
39+
val completionResultSet = session.resultSet
4040
val file = completionParameters.originalFile
4141
val cur = file.findElementAt(completionParameters.offset - 1)
4242
if (cur != null) {

src/main/java/com/tang/intellij/lua/editor/completion/SuggestSelfMemberProvider.kt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,8 @@
1616

1717
package com.tang.intellij.lua.editor.completion
1818

19-
import com.intellij.codeInsight.completion.CompletionParameters
20-
import com.intellij.codeInsight.completion.CompletionResultSet
2119
import com.intellij.codeInsight.lookup.LookupElement
2220
import com.intellij.psi.util.PsiTreeUtil
23-
import com.intellij.util.ProcessingContext
2421
import com.tang.intellij.lua.psi.LuaClassMember
2522
import com.tang.intellij.lua.psi.LuaClassMethodDef
2623
import com.tang.intellij.lua.psi.LuaPsiTreeUtil
@@ -35,9 +32,9 @@ import com.tang.intellij.lua.ty.isVisibleInScope
3532
* Created by TangZX on 2017/4/11.
3633
*/
3734
class SuggestSelfMemberProvider : ClassMemberCompletionProvider() {
38-
override fun addCompletions(completionParameters: CompletionParameters,
39-
processingContext: ProcessingContext,
40-
completionResultSet: CompletionResultSet) {
35+
override fun addCompletions(session: CompletionSession) {
36+
val completionParameters = session.parameters
37+
val completionResultSet = session.resultSet
4138
val position = completionParameters.position
4239
val methodDef = PsiTreeUtil.getParentOfType(position, LuaClassMethodDef::class.java)
4340
if (methodDef != null && !methodDef.isStatic) {

src/main/java/com/tang/intellij/lua/editor/completion/TableCompletionProvider.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,10 @@
1616

1717
package com.tang.intellij.lua.editor.completion
1818

19-
import com.intellij.codeInsight.completion.CompletionParameters
20-
import com.intellij.codeInsight.completion.CompletionResultSet
2119
import com.intellij.codeInsight.completion.PrioritizedLookupElement
2220
import com.intellij.codeInsight.lookup.LookupElement
2321
import com.intellij.codeInsight.lookup.LookupElementBuilder
2422
import com.intellij.psi.util.PsiTreeUtil
25-
import com.intellij.util.ProcessingContext
2623
import com.intellij.util.Processor
2724
import com.tang.intellij.lua.lang.LuaIcons
2825
import com.tang.intellij.lua.psi.LuaClassField
@@ -55,8 +52,9 @@ class TableCompletionProvider : ClassMemberCompletionProvider() {
5552
"__metatable" to "Meta method"
5653
)
5754
}
58-
59-
override fun addCompletions(completionParameters: CompletionParameters, processingContext: ProcessingContext, completionResultSet: CompletionResultSet) {
55+
override fun addCompletions(session: CompletionSession) {
56+
val completionParameters = session.parameters
57+
val completionResultSet = session.resultSet
6058
metaMethodNames.forEach {
6159
val b = LookupElementBuilder.create(it.key)
6260
.withTypeText(it.value)

0 commit comments

Comments
 (0)