completion: 限制 docfunction 补全项显示

Author: xuhuanzy

crates/emmylua_ls/src/handlers/completion/providers/member_provider.rs

@@ -1,4 +1,4 @@
-use emmylua_code_analysis::LuaMemberInfo;
+use emmylua_code_analysis::{LuaMemberInfo, LuaType};
 use emmylua_parser::{LuaAstNode, LuaAstToken, LuaIndexExpr, LuaStringToken};
 
 use crate::handlers::completion::{
@@ -59,23 +59,28 @@ fn add_resolve_member_infos(
         }
     }
 
-    match resolve_state {
-        MemberResolveState::All => {
-            for member_info in member_infos {
-                add_member_completion(builder, member_info.clone(), completion_status);
+    // 所有 DocFunction 只取第一个作为补全项
+    let mut find_doc_function = false;
+    for member_info in member_infos {
+        if matches!(member_info.typ, LuaType::DocFunction(_)) {
+            if find_doc_function {
+                continue;
             }
+            find_doc_function = true;
         }
-        MemberResolveState::Meta => {
-            for member_info in member_infos {
+
+        match resolve_state {
+            MemberResolveState::All => {
+                add_member_completion(builder, member_info.clone(), completion_status);
+            }
+            MemberResolveState::Meta => {
                 if let Some(feature) = member_info.feature {
                     if feature.is_meta_decl() {
                         add_member_completion(builder, member_info.clone(), completion_status);
                     }
                 }
             }
-        }
-        MemberResolveState::FileDecl => {
-            for member_info in member_infos {
+            MemberResolveState::FileDecl => {
                 if let Some(feature) = member_info.feature {
                     if feature.is_file_decl() {
                         add_member_completion(builder, member_info.clone(), completion_status);

crates/emmylua_ls/src/handlers/completion/test/completion_test.rs

@@ -105,11 +105,11 @@ mod tests {
         // 被动触发补全
         assert!(ws.check_completion_with_kind(
             r#"
-            ---@class Completion.Test4
+            ---@class Test
             ---@field event fun(a: "A", b: number)
             ---@field event fun(a: "B", b: string)
-            local Test4 = {}
-            Test4.event(<??>)
+            local Test = {}
+            Test.event(<??>)
         "#,
             vec![
                 VirtualCompletionItem {
@@ -127,11 +127,11 @@ mod tests {
         // 主动触发补全
         assert!(ws.check_completion(
             r#"
-                    ---@class Completion.Test4
+                    ---@class Test
                     ---@field event fun(a: "A", b: number)
                     ---@field event fun(a: "B", b: string)
-                    local Test4 = {}
-                    Test4.event(<??>)
+                    local Test = {}
+                    Test.event(<??>)
                 "#,
             vec![
                 VirtualCompletionItem {
@@ -143,10 +143,28 @@ mod tests {
                     kind: CompletionItemKind::ENUM_MEMBER,
                 },
                 VirtualCompletionItem {
-                    label: "Test4".to_string(),
+                    label: "Test".to_string(),
                     kind: CompletionItemKind::CLASS,
                 },
             ],
         ));
+
+        assert!(ws.check_completion(
+            r#"
+                    ---@class Test
+                    ---@field event fun(a: "A", b: number)
+                    ---@field event fun(a: "B", b: string)
+                    local Test = {}
+                    Test.<??>
+                "#,
+            vec![
+                VirtualCompletionItem {
+                    label: "event".to_string(),
+                    kind: CompletionItemKind::FUNCTION,
+                },
+            ],
+        ));
     }
+
+
 }