optimize type check

Author: CppCXY

crates/emmylua_code_analysis/src/db_index/type/types.rs

@@ -195,7 +195,7 @@ impl LuaType {
     pub fn is_table(&self) -> bool {
         matches!(
             self,
-            LuaType::Table | LuaType::TableGeneric(_) | LuaType::TableConst(_) | LuaType::Global
+            LuaType::Table | LuaType::TableGeneric(_) | LuaType::TableConst(_) | LuaType::Global | LuaType::Tuple(_)
         )
     }
 

crates/emmylua_code_analysis/src/semantic/type_check/func_type.rs

@@ -66,9 +66,16 @@ fn infer_doc_func_type_compact_for_params(
         compact_params.insert(0, ("self".to_string(), None));
     }
 
-    let source_len = source_params.len();
-    for i in 0..source_len {
-        let source_param = &source_params[i];
+    let compact_len = compact_params.len();
+    for i in 0..compact_len {
+        let source_param = match source_params.get(i) {
+            Some(p) => p,
+            None => {
+                return false;
+            }
+        };
+        let compact_param = &compact_params[i];
+
         let source_param_type = &source_param.1;
         // too many complex session to handle varargs
         if source_param.0 == "..." {
@@ -85,19 +92,6 @@ fn infer_doc_func_type_compact_for_params(
             return false;
         }
 
-        let compact_param = match compact_params.get(i) {
-            Some(p) => p,
-            None => {
-                if let Some(source_type) = &source_param.1 {
-                    if source_type.is_optional() {
-                        continue;
-                    }
-                };
-
-                return false;
-            }
-        };
-
         if compact_param.0 == "..." {
             break;
         }

crates/emmylua_code_analysis/src/semantic/type_check/mod.rs

@@ -78,7 +78,7 @@ fn infer_type_compact(
             LuaType::DocStringConst(t) => *s == t,
             _ => false,
         },
-        (LuaType::FloatConst(_), _) => compact_type.is_number(),
+        (LuaType::FloatConst(_), right) if right.is_number() => true,
         (LuaType::Table, _) => {
             compact_type.is_table()
                 || compact_type.is_array()