optimize hover and fix some bug

Author: CppCXY

crates/code_analysis/src/compilation/analyzer/doc/type_ref_tags.rs

@@ -167,7 +167,9 @@ pub fn analyze_return(analyzer: &mut DocAnalyzer, tag: LuaDocTagReturn) -> Optio
     } else {
         None
     };
+
     if let Some(closure) = find_owner_closure(analyzer) {
+        let signature_id = LuaSignatureId::new(analyzer.file_id, &closure);
         let returns = tag.get_type_and_name_list();
         for (doc_type, name_token) in returns {
             let name = if let Some(name) = name_token {
@@ -182,8 +184,11 @@ pub fn analyze_return(analyzer: &mut DocAnalyzer, tag: LuaDocTagReturn) -> Optio
                 type_ref,
                 description: description.clone(),
             };
-            let id = LuaSignatureId::new(analyzer.file_id, &closure);
-            let signature = analyzer.db.get_signature_index_mut().get_or_create(id);
+
+            let signature = analyzer
+                .db
+                .get_signature_index_mut()
+                .get_or_create(signature_id);
             signature.return_docs.push(return_info);
         }
     }

crates/code_analysis/src/compilation/analyzer/lua/stats.rs

@@ -27,7 +27,11 @@ pub fn analyze_local_stat(analyzer: &mut LuaAnalyzer, local_stat: LuaLocalStat)
         let expr = expr.unwrap();
         let expr_type = analyzer.infer_expr(expr);
         match expr_type {
-            Some(expr_type) => {
+            Some(mut expr_type) => {
+                if let LuaType::MuliReturn(multi) = expr_type {
+                    expr_type = multi.get_type(0)?.clone();
+                }
+
                 let decl_id = LuaDeclId::new(analyzer.file_id, position);
                 merge_decl_expr_type(analyzer.db, decl_id, expr_type);
             }

crates/code_analysis/src/db_index/type/types.rs

@@ -264,7 +264,7 @@ impl LuaType {
     }
 
     pub fn is_optional(&self) -> bool {
-        matches!(self, LuaType::Nil | LuaType::Nullable(_) | LuaType::Any)
+        matches!(self, LuaType::Nil | LuaType::Nullable(_))
     }
 
     pub fn is_tuple(&self) -> bool {

crates/code_analysis/src/diagnostic/checker/missing_parameter.rs

@@ -59,8 +59,13 @@ fn check_call_expr(
             }
 
             let typ = param_info.1.clone();
-            if typ.is_none() || !typ.unwrap().is_optional() {
+            if typ.is_none() {
                 miss_parameter_info.push(t!("missing parameter: %{name}", name = param_info.0));
+            } else if let Some(typ) = typ {
+                if !typ.is_any() && !typ.is_optional() {
+                    miss_parameter_info
+                        .push(t!("missing parameter: %{name}", name = param_info.0,));
+                }
             }
         }
 

crates/emmylua_ls/src/handlers/hover/build_hover.rs

@@ -191,18 +191,7 @@ fn add_signature_description(
         }
         s.push_str("\n");
     }
-
-    for return_info in &signature.return_docs {
-        s.push_str("@return ");
-        if let Some(name) = &return_info.name {
-            s.push_str(&format!("`{}`", name));
-        }
-        if let Some(description) = &return_info.description {
-            s.push_str(&format!(" - {}", description));
-        }
-        s.push_str("\n");
-    }
-
+    
     if !s.is_empty() {
         marked_strings.push(MarkedString::from_markdown(s));
     }