fix object type

Author: CppCXY

crates/emmylua_code_analysis/resources/std/table.lua

@@ -58,15 +58,6 @@ function table.insert(list, pos, value) end
 ---@return table
 function table.move(a1, f, e, t, a2) end
 
----
---- Returns a new table with all arguments stored into keys 1, 2, etc. and
---- with a field "`n`" with the total number of arguments. Note that the
---- resulting table may not be a sequence, if some arguments are **nil**.
----@generic T...
----@param ... T...
----@return [T...]
-function table.pack(...) end
-
 ---@version 5.1
 ---
 ---Returns the largest positive numerical index of the given table, or zero if the table has no positive numerical indices.
@@ -108,8 +99,8 @@ function table.remove(list, pos) end
 --- order may have their relative positions changed by the sort.
 ---@overload fun(list:table):number
 ---@generic V
----@param list table<number, V> | V[]
----@param comp? fun(a:V, b:V):boolean
+---@param list V[]
+---@param comp fun(a:V, b:V):boolean
 ---@return number
 function table.sort(list, comp) end
 
@@ -130,7 +121,7 @@ function table.unpack(list, i, j) end
 ---
 ---@generic T
 ---@param ... T...
----@return [T...] | { n: number }
+---@return [T...] | { n: integer }
 ---@nodiscard
 function table.pack(...) end
 

crates/emmylua_code_analysis/src/db_index/type/types.rs

@@ -555,6 +555,40 @@ impl LuaObjectType {
                 .iter()
                 .any(|(k, v)| k.contain_tpl() || v.contain_tpl())
     }
+
+    pub fn cast_down_array_base(&self) -> Option<LuaType> {
+        if self.index_access.len() != 0 {
+            return None;
+        }
+
+        let mut ty = LuaType::Unknown;
+        let mut count = 1;
+        let mut fields = self
+            .fields
+            .iter()
+            .collect::<Vec<_>>();
+
+        fields.sort_by(|(a, _), (b, _)| a.cmp(b));
+
+        for (key, value_type) in fields {
+            let idx = match key {
+                LuaMemberKey::Integer(i) => i,
+                _ => {
+                    return None;
+                }
+            };
+
+            if *idx != count {
+                return None;
+            }
+
+            count += 1;
+
+            ty = TypeOps::Union.apply(&ty, value_type);
+        }
+
+        Some(ty)
+    }
 }
 
 impl From<LuaObjectType> for LuaType {

crates/emmylua_code_analysis/src/diagnostic/test/param_type_check_test.rs

@@ -206,4 +206,18 @@ mod test {
         "#
         ));
     }
+
+    #[test]
+    fn test_issue_95() {
+        let mut ws = VirtualWorkspace::new_with_init_std_lib();
+
+        assert!(ws.check_code_for(
+            DiagnosticCode::ParamTypeNotMatch,
+            r#"
+        local range ---@type { [1]: integer, [2]: integer }
+
+        table.sort(range)
+        "#
+        ));
+    }
 }

crates/emmylua_code_analysis/src/semantic/instantiate/tpl_pattern.rs

@@ -78,6 +78,10 @@ fn array_tpl_pattern_match(
             let target_base = target_tuple.cast_down_array_base();
             tpl_pattern_match(db, config, root, base, &target_base, substitutor);
         }
+        LuaType::Object(target_object) => {
+            let target_base = target_object.cast_down_array_base()?;
+            tpl_pattern_match(db, config, root, base, &target_base, substitutor);
+        }
         _ => {}
     }
 

crates/emmylua_code_analysis/src/semantic/type_check/complex_type.rs

@@ -52,6 +52,17 @@ pub fn check_complex_type_compact(
                     check_guard.next_level()?,
                 );
             }
+            LuaType::Object(compact_object) => {
+                let compact_base = compact_object
+                    .cast_down_array_base()
+                    .ok_or(TypeCheckFailReason::TypeNotMatch)?;
+                return check_general_type_compact(
+                    db,
+                    source_base,
+                    &compact_base,
+                    check_guard.next_level()?,
+                );
+            }
             LuaType::Table => return Ok(()),
             _ => {}
         },