fix union_tpl_pattern_match

Author: xuhuanzy

crates/emmylua_code_analysis/src/diagnostic/test/param_type_check_test.rs

@@ -1380,4 +1380,42 @@ mod test {
         "#
         ));
     }
+
+    #[test]
+    fn test_pairs_1() {
+        let mut ws = VirtualWorkspace::new();
+        ws.def(
+            r#"
+        ---@param value string
+        function aaaa(value)
+        end
+
+        ---@generic K, V
+        ---@param t {[K]: V} | V[]
+        ---@return fun(tbl: any):K, V
+        function pairs(t) end
+        "#,
+        );
+        assert!(!ws.check_code_for(
+            DiagnosticCode::ParamTypeMismatch,
+            r#"
+            ---@type {[string]: number}
+            local matchers = {}
+            for _, matcher in pairs(matchers) do
+                aaaa(matcher)
+            end
+        "#
+        ));
+        assert!(!ws.check_code_for(
+            DiagnosticCode::ParamTypeMismatch,
+            r#"
+            ---@alias MatchersObject {[string]: number}
+            ---@type MatchersObject
+            local matchers = {}
+            for _, matcher in pairs(matchers) do
+                aaaa(matcher)
+            end
+        "#
+        ));
+    }
 }

crates/emmylua_code_analysis/src/semantic/generic/instantiate_type/instantiate_func_generic.rs

@@ -160,7 +160,6 @@ fn infer_generic_types_from_call(
         }
 
         let arg_type = infer_expr(db, context.cache, call_arg_expr.clone())?;
-
         match (func_param_type, &arg_type) {
             (LuaType::Variadic(variadic), _) => {
                 let mut arg_types = vec![];

crates/emmylua_code_analysis/src/semantic/generic/tpl_pattern/mod.rs

@@ -509,11 +509,24 @@ fn union_tpl_pattern_match(
     union: &LuaUnionType,
     target: &LuaType,
 ) -> TplPatternMatchResult {
+    let mut error_count = 0;
+    let mut last_error = InferFailReason::None;
     for u in union.into_vec() {
-        tpl_pattern_match(context, &u, target)?;
+        match tpl_pattern_match(context, &u, target) {
+            // 返回 ok 时并不一定匹配成功, 仅表示没有发生错误
+            Ok(_) => {}
+            Err(e) => {
+                error_count += 1;
+                last_error = e;
+            }
+        }
     }
 
-    Ok(())
+    if error_count == union.into_vec().len() {
+        Err(last_error)
+    } else {
+        Ok(())
+    }
 }
 
 fn func_tpl_pattern_match(