update readonly check

Author: CppCXY

crates/emmylua_code_analysis/src/diagnostic/checker/readonly_check.rs

@@ -1,8 +1,9 @@
-use emmylua_parser::{LuaAssignStat, LuaAst, LuaAstNode, LuaVarExpr};
+use emmylua_parser::{LuaAssignStat, LuaAst, LuaAstNode, LuaExpr, LuaSyntaxId, LuaSyntaxKind};
 use rowan::{NodeOrToken, TextRange};
 
 use crate::{
-    DiagnosticCode, LuaSemanticDeclId, PropertyDeclFeature, SemanticDeclLevel, SemanticModel,
+    DiagnosticCode, LuaDeclId, LuaMemberId, LuaSemanticDeclId, PropertyDeclFeature,
+    SemanticDeclLevel, SemanticModel,
 };
 
 use super::{Checker, DiagnosticContext};
@@ -34,6 +35,23 @@ fn check_and_report_semantic_id(
     range: TextRange,
     semantic_decl_id: LuaSemanticDeclId,
 ) -> Option<()> {
+    match semantic_decl_id {
+        LuaSemanticDeclId::LuaDecl(decl_id) => {
+            let self_decl_id = LuaDeclId::new(context.file_id, range.start());
+            if decl_id == self_decl_id {
+                return None;
+            }
+        }
+        LuaSemanticDeclId::Member(member_id) => {
+            let syntax_id = LuaSyntaxId::new(LuaSyntaxKind::IndexExpr.into(), range);
+            let self_member_id = LuaMemberId::new(syntax_id, context.file_id);
+            if member_id == self_member_id {
+                return None;
+            }
+        }
+        _ => {}
+    }
+
     // TODO filter self
     let property_index = context.db.get_property_index();
     if let Some(property) = property_index.get_property(&semantic_decl_id) {
@@ -60,28 +78,22 @@ fn check_assign_stat(
 ) -> Option<()> {
     let (vars, _) = assign_stat.get_var_and_expr_list();
     for var in vars {
-        let node_or_token = NodeOrToken::Node(var.syntax().clone());
-        let semantic_decl_id =
-            semantic_model.find_decl(node_or_token, SemanticDeclLevel::default());
-        if let Some(semantic_decl_id) = semantic_decl_id {
-            check_and_report_semantic_id(context, var.get_range(), semantic_decl_id);
-        }
-
-        match var {
-            LuaVarExpr::IndexExpr(index_expr) => {
-                let prefix_node = index_expr.get_prefix_expr()?;
-                let node_or_token = NodeOrToken::Node(prefix_node.syntax().clone());
-                let semantic_decl_id =
-                    semantic_model.find_decl(node_or_token, SemanticDeclLevel::default());
-                if let Some(semantic_decl_id) = semantic_decl_id {
-                    check_and_report_semantic_id(
-                        context,
-                        prefix_node.get_range(),
-                        semantic_decl_id,
-                    );
+        let mut var = LuaExpr::cast(var.syntax().clone())?;
+        loop {
+            let node_or_token = NodeOrToken::Node(var.syntax().clone());
+            let semantic_decl_id =
+                semantic_model.find_decl(node_or_token, SemanticDeclLevel::default());
+            if let Some(semantic_decl_id) = semantic_decl_id {
+                check_and_report_semantic_id(context, var.get_range(), semantic_decl_id);
+            }
+            match var {
+                LuaExpr::IndexExpr(index_expr) => {
+                    var = index_expr.get_prefix_expr()?;
+                }
+                _ => {
+                    break;
                 }
             }
-            _ => {}
         }
     }
 

crates/emmylua_code_analysis/src/semantic/semantic_info/infer_expr_semantic_decl.rs

@@ -75,15 +75,16 @@ fn infer_name_expr_semantic_decl(
         .get_type_index()
         .get_type_cache(&decl_id.into())
         .unwrap_or(&LuaTypeCache::InferType(LuaType::Unknown));
-    let is_function = decl_type.is_function();
-    if decl.is_local() && !is_function {
+    let is_ref_object = decl_type.is_function() || decl_type.is_table();
+    if decl.is_local() && !is_ref_object {
         return Some(LuaSemanticDeclId::LuaDecl(decl_id));
     }
 
     if level.reached_limit() {
         return Some(LuaSemanticDeclId::LuaDecl(decl_id));
     }
 
+    // should continue infer require?
     if let Some(value_expr_id) = decl.get_value_syntax_id()
         && matches!(
             value_expr_id.get_kind(),