completion: 限制空格补全范围

Author: xuhuanzy

crates/emmylua_ls/src/handlers/completion/completion_builder.rs

@@ -12,13 +12,16 @@ pub struct CompletionBuilder<'a> {
     completion_items: Vec<CompletionItem>,
     cancel_token: CancellationToken,
     stopped: bool,
+    // 主动触发补全
+    pub is_invoke_completion: bool,
 }
 
 impl<'a> CompletionBuilder<'a> {
     pub fn new(
         trigger_token: LuaSyntaxToken,
         semantic_model: SemanticModel<'a>,
         cancel_token: CancellationToken,
+        is_invoke_completion: bool,
     ) -> Self {
         Self {
             trigger_token,
@@ -27,6 +30,7 @@ impl<'a> CompletionBuilder<'a> {
             completion_items: Vec::new(),
             cancel_token,
             stopped: false,
+            is_invoke_completion,
         }
     }
 

crates/emmylua_ls/src/handlers/completion/mod.rs

@@ -11,7 +11,7 @@ use emmylua_parser::LuaAstNode;
 use log::error;
 use lsp_types::{
     ClientCapabilities, CompletionItem, CompletionOptions, CompletionOptionsCompletionItem,
-    CompletionParams, CompletionResponse, ServerCapabilities,
+    CompletionParams, CompletionResponse, CompletionTriggerKind, ServerCapabilities,
 };
 use providers::add_completions;
 use resolve_completion::resolve_completion;
@@ -52,7 +52,15 @@ pub async fn on_completion_handler(
         }
     };
 
-    let mut builder = CompletionBuilder::new(token, semantic_model, cancel_token);
+    let mut builder = CompletionBuilder::new(
+        token,
+        semantic_model,
+        cancel_token,
+        params
+            .context
+            .map(|context| context.trigger_kind == CompletionTriggerKind::INVOKED)
+            .unwrap_or(false),
+    );
     add_completions(&mut builder);
     Some(CompletionResponse::Array(builder.get_completion_items()))
 }

crates/emmylua_ls/src/handlers/completion/providers/mod.rs

@@ -11,12 +11,24 @@ mod postfix_provider;
 mod table_decl_field_provider;
 mod type_special_provider;
 
-use emmylua_parser::{LuaAstToken, LuaStringToken};
+use emmylua_parser::{LuaAst, LuaAstNode, LuaAstToken, LuaStringToken};
 use rowan::TextRange;
 
 use super::completion_builder::CompletionBuilder;
 
 pub fn add_completions(builder: &mut CompletionBuilder) -> Option<()> {
+    // 空格补全只允许在非主动且位于函数调用参数列表中触发
+    if builder.get_trigger_text().is_empty() && !builder.is_invoke_completion {
+        let node = LuaAst::cast(builder.trigger_token.parent()?)?;
+        match node {
+            LuaAst::LuaCallArgList(_) => {
+                type_special_provider::add_completion(builder);
+                return Some(());
+            }
+            _ => return Some(()),
+        }
+    }
+
     module_path_provider::add_completion(builder);
     file_path_provider::add_completion(builder);
     keywords_provider::add_completion(builder);