optimize hover desc

Author: xuhuanzy

crates/emmylua_ls/src/handlers/hover/build_hover.rs

@@ -1,3 +1,5 @@
+use std::collections::HashSet;
+
 use emmylua_code_analysis::{
     DbIndex, LuaDeclId, LuaDocument, LuaMemberId, LuaMemberKey, LuaSemanticDeclId, LuaSignatureId,
     LuaType, LuaTypeDeclId, RenderLevel, SemanticInfo, SemanticModel,
@@ -174,8 +176,11 @@ fn build_decl_hover(
         }
 
         // 添加注释文本
-        builder.add_description(&LuaSemanticDeclId::LuaDecl(decl_id));
-        for (semantic_decl, _) in semantic_decls {
+        let mut semantic_decl_set = HashSet::new();
+        let decl_decl = LuaSemanticDeclId::LuaDecl(decl_id);
+        semantic_decl_set.insert(&decl_decl);
+        semantic_decl_set.extend(semantic_decls.iter().map(|(decl, _)| decl));
+        for semantic_decl in semantic_decl_set {
             builder.add_description(&semantic_decl);
         }
     }
@@ -239,9 +244,12 @@ fn build_member_hover(
         }
 
         // 添加注释文本
-        builder.add_description(&LuaSemanticDeclId::Member(member.get_id()));
-        for (semantic_decl, _) in semantic_decls {
-            builder.add_description(&semantic_decl);
+        let mut semantic_decl_set = HashSet::new();
+        let member_decl = LuaSemanticDeclId::Member(member.get_id());
+        semantic_decl_set.insert(&member_decl);
+        semantic_decl_set.extend(semantic_decls.iter().map(|(decl, _)| decl));
+        for semantic_decl in semantic_decl_set {
+            builder.add_description(semantic_decl);
         }
     }
 

crates/emmylua_ls/src/handlers/hover/find_origin.rs

@@ -250,17 +250,24 @@ pub fn replace_semantic_type(
     match origin_type {
         LuaType::Union(union) => {
             for typ in union.get_types() {
-                type_vec.push(typ.clone());
+                type_vec.push(typ);
             }
         }
         _ => {
-            type_vec.push(origin_type.clone());
+            type_vec.push(origin_type);
         }
     }
     if type_vec.len() != semantic_decls.len() {
         return;
     }
 
+    // 判断是否存在泛型, 如果有任意类型不匹配我们就认为存在泛型
+    for (_, typ) in semantic_decls.iter() {
+        if !type_vec.iter().any(|t| *t == typ) {
+            break;
+        }
+    }
+
     // 替换`semantic_decls`中的类型
     for (i, (_, typ)) in semantic_decls.iter_mut().enumerate() {
         if i < type_vec.len() {

crates/emmylua_ls/src/handlers/test/hover_test.rs

@@ -118,4 +118,23 @@ mod tests {
             },
         ));
     }
+
+    #[test]
+    fn test_decl_desc() {
+        let mut ws = ProviderVirtualWorkspace::new();
+        assert!(ws.check_hover(
+            r#"
+                ---@class Buff.AddData
+                ---@field pulse? number 心跳周期
+
+                ---@type Buff.AddData
+                local data
+
+                data.pu<??>lse
+            "#,
+            VirtualHoverResult {
+                value: "\n```lua\n(field) pulse: number?\n```\n\n&nbsp;&nbsp;in class `Buff.AddData`\n\n---\n\n心跳周期\n".to_string(),
+            },
+        ));
+    }
 }