fix infer_call_expr_func && fix resolve_signature

Author: xuhuanzy

crates/emmylua_code_analysis/src/diagnostic/test/param_type_check_test.rs

@@ -776,4 +776,78 @@ mod test {
         "#
         ));
     }
+
+    #[test]
+    fn test_function_union() {
+        let mut ws = VirtualWorkspace::new();
+        assert!(!ws.check_code_for(
+            DiagnosticCode::ParamTypeNotMatch,
+            r#"
+                ---@class (partial) D21.A
+                local M
+
+                ---@alias EventType
+                ---| GlobalEventType
+                ---| UIEventType
+
+                ---@enum UIEventType
+                local UIEventType = {
+                    ['UI_CREATE'] = "ET_UI_PREFAB_CREATE_EVENT",
+                }
+                ---@enum GlobalEventType
+                local GlobalEventType = {
+                    ['GAME_INIT'] = "ET_GAME_INIT",
+                }
+
+                ---@param event_type EventType
+                function M:event(event_type)
+                end
+
+                ---@class (partial) D21.A
+                ---@field event fun(self: self, event: "游戏-初始化")
+
+                ---@param p string
+                local function test(p)
+                    M:event(p)
+                end
+        "#
+        ));
+    }
+
+    #[test]
+    fn test_function_union_2() {
+        let mut ws = VirtualWorkspace::new();
+        assert!(ws.check_code_for(
+            DiagnosticCode::ParamTypeNotMatch,
+            r#"
+                ---@class (partial) D21.A
+                local M
+
+                ---@alias EventType
+                ---| GlobalEventType
+                ---| UIEventType
+
+                ---@enum UIEventType
+                local UIEventType = {
+                    ['UI_CREATE'] = "ET_UI_PREFAB_CREATE_EVENT",
+                }
+                ---@enum GlobalEventType
+                local GlobalEventType = {
+                    ['GAME_INIT'] = "ET_GAME_INIT",
+                }
+
+                ---@param event_type EventType
+                function M:event(event_type)
+                end
+
+                ---@class (partial) D21.A
+                ---@field event fun(self: self, event: "游戏-初始化")
+
+                ---@param p EventType
+                local function test(p)
+                    M:event(p)
+                end
+        "#
+        ));
+    }
 }

crates/emmylua_code_analysis/src/semantic/infer/infer_call_func.rs

@@ -76,15 +76,14 @@ pub fn infer_call_expr_func(
         LuaType::TableConst(meta_table) => infer_table_type_doc_function(db, meta_table),
         LuaType::Union(union) => {
             // 此时我们将其视为泛型实例化联合体
-            if union.get_types().len() > 1
-                && union
-                    .get_types()
-                    .iter()
-                    .all(|t| matches!(t, LuaType::DocFunction(_)))
+            if union
+                .get_types()
+                .iter()
+                .all(|t| matches!(t, LuaType::DocFunction(_)))
             {
                 infer_generic_doc_function_union(db, cache, &union, call_expr, args_count)
             } else {
-                Err(InferFailReason::None)
+                infer_union(db, cache, &union, call_expr, args_count)
             }
         }
         _ => return Err(InferFailReason::None),
@@ -384,3 +383,79 @@ fn infer_table_type_doc_function(db: &DbIndex, table: InFiled<TextRange>) -> Inf
 
     Err(InferFailReason::None)
 }
+
+fn infer_union(
+    db: &DbIndex,
+    cache: &mut LuaInferCache,
+    union: &LuaUnionType,
+    call_expr: LuaCallExpr,
+    args_count: Option<usize>,
+) -> InferCallFuncResult {
+    // 此时一般是 signature + doc_function 的联合体
+    let mut all_overloads = Vec::new();
+    let mut base_signatures = Vec::new();
+
+    for ty in union.get_types() {
+        match ty {
+            LuaType::Signature(signature_id) => {
+                if let Some(signature) = db.get_signature_index().get(signature_id) {
+                    // 处理 overloads
+                    let overloads = if signature.is_generic() {
+                        signature
+                            .overloads
+                            .iter()
+                            .map(|func| {
+                                Ok(Arc::new(instantiate_func_generic(
+                                    db,
+                                    cache,
+                                    func,
+                                    call_expr.clone(),
+                                )?))
+                            })
+                            .collect::<Result<Vec<_>, _>>()?
+                    } else {
+                        signature.overloads.clone()
+                    };
+                    all_overloads.extend(overloads);
+
+                    // 处理 signature 本身的函数类型
+                    let mut fake_doc_function = LuaFunctionType::new(
+                        signature.is_async,
+                        signature.is_colon_define,
+                        signature.get_type_params(),
+                        signature.get_return_types(),
+                    );
+                    if signature.is_generic() {
+                        fake_doc_function = instantiate_func_generic(
+                            db,
+                            cache,
+                            &fake_doc_function,
+                            call_expr.clone(),
+                        )?;
+                    }
+                    base_signatures.push(Arc::new(fake_doc_function));
+                }
+            }
+            LuaType::DocFunction(func) => {
+                let func_to_push = if func.contain_tpl() {
+                    Arc::new(instantiate_func_generic(
+                        db,
+                        cache,
+                        func,
+                        call_expr.clone(),
+                    )?)
+                } else {
+                    func.clone()
+                };
+                base_signatures.push(func_to_push);
+            }
+            _ => {}
+        }
+    }
+
+    all_overloads.extend(base_signatures);
+    if all_overloads.is_empty() {
+        return Err(InferFailReason::None);
+    }
+    resolve_signature(db, cache, all_overloads, call_expr, false, args_count)
+}

crates/emmylua_code_analysis/src/semantic/overload_resolve/mod.rs

@@ -86,6 +86,11 @@ fn resolve_signature_by_args(
             jump_param = 0;
         };
 
+        // 冒号定义且冒号调用
+        if is_colon_call && func.is_colon_define() {
+            total_weight += 100;
+        }
+
         // 检查每个参数的匹配情况
         for (i, param) in params.iter().enumerate() {
             if i == 0 && jump_param > 0 {