check_field 完善

Author: xuhuanzy

crates/emmylua_code_analysis/src/diagnostic/checker/check_field.rs

@@ -143,6 +143,7 @@ fn is_valid_member(
 
     match prefix_typ {
         LuaType::Global => return Some(()),
+        LuaType::Userdata => return Some(()),
         LuaType::Array(typ) => {
             if typ.is_unknown() {
                 return Some(());
@@ -233,6 +234,22 @@ fn is_valid_member(
                     _ => {}
                 }
             }
+            if members.is_empty() {
+                // 当没有任何成员信息且是 enum 类型时, 需要检查参数是否为自己
+                if let LuaType::Ref(id) | LuaType::Def(id) = prefix_type {
+                    if let Some(decl) = semantic_model.get_db().get_type_index().get_type_decl(&id)
+                    {
+                        if decl.is_enum() {
+                            if key_type_set.iter().any(|typ| match typ {
+                                LuaType::Ref(key_id) | LuaType::Def(key_id) => id == *key_id,
+                                _ => false,
+                            }) {
+                                return Some(());
+                            }
+                        }
+                    }
+                }
+            }
         }
     }
 
@@ -276,6 +293,9 @@ fn get_key_types(typ: &LuaType) -> HashSet<LuaType> {
                     stack.push(t.clone());
                 }
             }
+            LuaType::Ref(_) => {
+                type_set.insert(current_type);
+            }
             _ => {}
         }
     }

crates/emmylua_code_analysis/src/diagnostic/test/undefined_field_test.rs

@@ -383,4 +383,72 @@ mod test {
         "#
         ));
     }
+
+    #[test]
+    fn test_enum_3() {
+        let mut ws = VirtualWorkspace::new();
+        assert!(ws.check_code_for(
+            DiagnosticCode::UndefinedField,
+            r#"
+            ---@enum (key) PlayerAttr
+            local PlayerAttr = {}
+
+            ---@param key PlayerAttr
+            local function add(key)
+                local a = PlayerAttr[key]
+            end
+        "#
+        ));
+    }
+
+    #[test]
+    fn test_enum_alias() {
+        let mut ws = VirtualWorkspace::new();
+        assert!(ws.check_code_for(
+            DiagnosticCode::UndefinedField,
+            r#"
+                ---@enum EA
+                A = {
+                    ['GAME_INIT'] = "ET_GAME_INIT",
+                }
+
+                ---@enum EB
+                B = {
+                    ['GAME_PAUSE'] = "ET_GAME_PAUSE",
+                }
+
+                ---@alias EventName EA | EB
+
+                ---@class Event
+                local event = {}
+                event.ET_GAME_INIT = {}
+                event.ET_GAME_PAUSE = {}
+
+
+                ---@param name EventName
+                local function test(name)
+                    local a = event[name]
+                end
+        "#
+        ));
+    }
+
+    #[test]
+    fn test_userdata() {
+        let mut ws = VirtualWorkspace::new();
+        assert!(ws.check_code_for(
+            DiagnosticCode::UndefinedField,
+            r#"
+            ---@type any
+            local value
+            local tp = type(value)
+
+            if tp == 'userdata' then
+                ---@cast value userdata
+                if value['type'] then
+                end
+            end
+        "#
+        ));
+    }
 }

crates/emmylua_code_analysis/src/semantic/infer/infer_index.rs

@@ -327,8 +327,12 @@ fn get_all_member_key(
         LuaType::MultiLineUnion(types) => {
             for (typ, _) in types.get_unions() {
                 let member_key: LuaMemberKey = match typ {
-                    LuaType::DocStringConst(s) => (*s).to_string().into(),
-                    LuaType::IntegerConst(i) => (*i).into(),
+                    LuaType::DocStringConst(s) | LuaType::StringConst(s) => (*s).to_string().into(),
+                    LuaType::DocIntegerConst(i) | LuaType::IntegerConst(i) => (*i).into(),
+                    LuaType::Ref(_) => {
+                        get_all_member_key(db, index_type_decl, typ, result);
+                        continue;
+                    }
                     _ => continue,
                 };